Skip to content

[ArPow] Add patches for building more roslyn projects#12397

Merged
MichaelSimons merged 5 commits into
dotnet:release/6.0.1xxfrom
lbussell:roslyn-build-more-projects
Oct 20, 2021
Merged

[ArPow] Add patches for building more roslyn projects#12397
MichaelSimons merged 5 commits into
dotnet:release/6.0.1xxfrom
lbussell:roslyn-build-more-projects

Conversation

@lbussell
Copy link
Copy Markdown
Member

@lbussell lbussell commented Oct 15, 2021 •
edited
Loading

This is the patch version of dotnet/roslyn#57165

Details in this comment: dotnet/roslyn#57165 (comment)

@lbussell lbussell force-pushed the roslyn-build-more-projects branch from 10d3ac3 to 407de8d Compare October 15, 2021 22:53
@lbussell lbussell changed the title Add patches for building more roslyn projects [ArPow] Add patches for building more roslyn projects Oct 19, 2021
@lbussell lbussell requested a review from dagood October 19, 2021 17:48
@lbussell lbussell marked this pull request as ready for review October 19, 2021 17:48
@lbussell lbussell requested a review from a team as a code owner October 19, 2021 17:48
@lbussell lbussell force-pushed the roslyn-build-more-projects branch from 94d7a35 to 3510475 Compare October 19, 2021 19:25
dagood
dagood approved these changes Oct 19, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@dagood dagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some minor suggestions.

Comment thread ...eBuild/tarball/patches/roslyn/0006-force-Microsoft.Build-to-16.5.0-with-RefOnly-prefix.patch
Comment thread src/SourceBuild/tarball/patches/roslyn/0005-Exclude-src-Dependencies-from-source-build.patch Outdated
@MichaelSimons MichaelSimons mentioned this pull request Oct 19, 2021
Merged
MichaelSimons
MichaelSimons approved these changes Oct 19, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for tackling this one!

@dagood dagood disabled auto-merge October 19, 2021 23:15
@MichaelSimons
Copy link
Copy Markdown
Member

MichaelSimons commented Oct 20, 2021

@dagood - are you alright with merging this now that the Microsoft.CodeAnalysis.Features.* have been removed?

@MichaelSimons
Copy link
Copy Markdown
Member

MichaelSimons commented Oct 20, 2021 •
edited
Loading

Once merge we should open a separate issue to address the Microsoft.VisualStudio.Setup.Configuration.Interop prebuilt, which if I understand correctly involves bringing a 5.0 patch forward.

I was expecting Microsoft.CodeAnalysis.Collections to come in with this PR as well to eliminate the last msbuild prebuilt but I'm not seeing it. Am I misunderstanding something?

@dagood
Copy link
Copy Markdown
Member

dagood commented Oct 20, 2021

I was expecting Microsoft.CodeAnalysis.Collections to come in with this PR as well to eliminate the last msbuild prebuilt but I'm not seeing it. Am I misunderstanding something?

The plan changed, this is going into SBRP separately. dotnet/source-build#2517

@MichaelSimons MichaelSimons merged commit 286b597 into dotnet:release/6.0.1xx Oct 20, 2021
@dagood
Copy link
Copy Markdown
Member

dagood commented Oct 20, 2021

Once merge we should open a separate issue to address the Microsoft.VisualStudio.Setup.Configuration.Interop prebuilt, which if I understand correctly involves bringing a 5.0 patch forward.

Filed dotnet/source-build#2542

@dagood dagood mentioned this pull request Oct 20, 2021
Closed
@lbussell lbussell mentioned this pull request Oct 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelSimons MichaelSimons MichaelSimons approved these changes

@dagood dagood dagood approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lbussell @MichaelSimons @dagood