Integrate new user-jwts tool into installer (#13895)#13913
Merged
Conversation
dougbu
reviewed
Jun 6, 2022
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
This looks good to me but should there be a test or two of the tool in this repo❔
|
I think my question is mostly for you @marcpopMSFT |
Author
There are tests that validate the |
Member
|
SDK repo is for depth feature testing. The installer repo is more for breadth E2E testing (technically we can choose to run sdk tests in this repo as well). I'd put tests in the sdk repo as Safia has done and I probably wouldn't include it in the set of sdk tests run here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward port of #13895 to preview6.
Depends on #13860.