Skip to content

[main] Integrate dotnet user-jwts tools into SDK#25757

Merged
captainsafia merged 7 commits into
mainfrom
safia/dotnet-user-jwts
Jun 3, 2022
Merged

[main] Integrate dotnet user-jwts tools into SDK#25757
captainsafia merged 7 commits into
mainfrom
safia/dotnet-user-jwts

Conversation

@captainsafia
Copy link
Copy Markdown
Contributor

Part 1 of the integration of the user-jwts tool into the SDK.

@ghost ghost added the Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, StaticWebAssetsSDK label Jun 1, 2022
@captainsafia captainsafia requested a review from dsplaisted June 1, 2022 19:41
@captainsafia captainsafia changed the title Integrate dotnet user-jwts tools into SDK [main] Integrate dotnet user-jwts tools into SDK Jun 1, 2022
@captainsafia captainsafia requested a review from a team June 2, 2022 16:07
@captainsafia
Copy link
Copy Markdown
Contributor Author

FYI: @marcpopMSFT We're adding a new tool to the dotnet SDK. The source code for this tool lives in the ASP.NET Core repo so no meaningful impact to build times/issue triage here.

Copy link
Copy Markdown
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming these are the only places tools like dotnet-watch are mentioned in the repo

@captainsafia
Copy link
Copy Markdown
Contributor Author

Looks good, assuming these are the only places tools like dotnet-watch are mentioned in the repo

Yep, I've actually been using dotnet-dev-certs and dotnet-user-secrets as templates since they are also built outside the SDK. dotnet-watch lives in the SDK.

@captainsafia captainsafia enabled auto-merge (squash) June 2, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, StaticWebAssetsSDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants