Add a VMR initialization (bootstrap) process#14343
Merged
Merged
Conversation
MichaelSimons
approved these changes
Aug 19, 2022
Member
MichaelSimons
left a comment
MichaelSimons
left a comment
There was a problem hiding this comment.
LGTM - One minor suggestion.
crummel
reviewed
Aug 19, 2022
crummel
left a comment
crummel
left a comment
There was a problem hiding this comment.
Couple suggestions/questions but this is looking pretty good, cool.
mmitche
reviewed
Aug 19, 2022
mmitche
reviewed
Aug 19, 2022
(brings fix to checking out off-branch SHAs)
mmitche
reviewed
Aug 22, 2022
mmitche
approved these changes
Aug 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: dotnet/arcade#10285
This PR adds the possibility to initialize a fresh VMR off of the current
dotnet/installercommit.Similarly to the tarball generation, the process can be triggered by running:
The process is not yet 100% complete but it's a majority and a good start. Large portion is a re-use of the tarball generation process to follow how the tarball is put together.
Outstanding questions/work
It is trivially easy to apply them at the beginning but we haven't decided yet how exactly to tackle this issue so it's not part of this PR yet.
DarcLib code flow (10492)We can discuss this in this PR probably - not sure how we want thearcade-services->installersubscription to be made.Resolves dotnet/arcade#10266
Resolves dotnet/arcade#10265
Related dotnet/arcade#10264
Related dotnet/arcade#10262