Update referenced SDK version for source build#17909
Merged
mthalman merged 1 commit intodotnet:mainfrom Dec 5, 2023
Merged
Conversation
MichaelSimons
approved these changes
Dec 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build of the SBRP repo in the VMR is failing for offline builds with this error:
This occurs when attempting to build a project that references
net8.0. It attempts to load the RC2 version of Microsoft.NETCore.App.Ref because the currently referenced SDK version is referencing RC2 in its Microsoft.NETCoreSdk.BundledVersions.props file.These changes bootstrap source build with a newer SDK version which has an updated Microsoft.NETCoreSdk.BundledVersions.props file that references 8.0.0 instead.
Use of the 8.0.0 version will succeed in the build because SBRP has already been updated to include a targeting pack for that version: dotnet/source-build-reference-packages#829