Add Microsoft.NETCore.App.Ref.8.0.0 targeting pack#829
Merged
mthalman merged 1 commit intodotnet:mainfrom Nov 17, 2023
Merged
Conversation
mthalman
requested review from
MichaelSimons and
oleksandr-didyk
as code owners
MichaelSimons
approved these changes
Nov 17, 2023
ericstj
pushed a commit
to ericstj/source-build-reference-packages
that referenced
this pull request
Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes from #822 are causing a prebuilt for Microsoft.NETCore.App.Ref.8.0.0 when building the VMR with a .NET 9 SDK. That's because a 8.0 targeting pack is needed in that scenario.
These changes add the 8.0 Microsoft.NETCore.App.Ref targeting pack to SBRP so there's not an attempt made to restore it and cause a prebuilt.