[release/5.0.1xx-preview1] Update dependencies from dotnet/windowsdesktop#6473
Conversation
…ld 20200219.4 - Microsoft.WindowsDesktop.App - 5.0.0-preview.1.20119.4 - Microsoft.WindowsDesktop.App.Ref - 5.0.0-preview.1.20119.4 - Microsoft.WindowsDesktop.App.Runtime.win-x64 - 5.0.0-preview.1.20119.4 Dependency coherency updates - Microsoft.Dotnet.WinForms.ProjectTemplates - 5.0.0-preview.1.20118.1 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64) - Microsoft.DotNet.Wpf.ProjectTemplates - 5.0.0-preview.1.20119.9 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)
This comment has been minimized.
This comment has been minimized.
Indeed, the blob doesn't exist - there is no |
This comment has been minimized.
This comment has been minimized.
|
@MattGal another infra problem ? |
This comment has been minimized.
This comment has been minimized.
|
Retrying |
This comment has been minimized.
This comment has been minimized.
|
No dice
EDIT: Sorry for the duplicate information to above |
This comment has been minimized.
This comment has been minimized.
sounds like an azure storage issue but I'm taking a look to be sure. |
This comment has been minimized.
This comment has been minimized.
|
I verified the latest up there is |
|
I believe from dotnet/windowsdesktop repo |
This comment has been minimized.
This comment has been minimized.
OK... not super familiar with them but I'll go see if I can hunt down a publish failure in their builds. |
|
Should be from https://dev.azure.com/dnceng/internal/_build/results?buildId=528751&view=results. Maybe the channel isn't configured right to publish to dotnetcli blob storage? |
This comment has been minimized.
This comment has been minimized.
|
Ah yep, no 5p1 channel configuration in https://github.com/dotnet/windowsdesktop/blob/2bfe43eb8e4fc90388a150634dab891b2aa15ef4/azure-pipelines.yml#L87-L101. Should consider porting dotnet/core-setup#8426 to that repo so channel additions aren't necessarily breaking changes. |
This comment has been minimized.
This comment has been minimized.
|
Who's on point to fix this? |
|
Thanks for tracking that down! |
|
@NikolaMilosavljevic is probably the right person to take point on this since it's an issue in windowsdesktop infra inherited from core-setup. I'll work with him to get this addressed quickly. |
This comment has been minimized.
This comment has been minimized.
👍 Should this be fixed in master as well? /cc @dotnet/wpf-developers , @RussKie, @AdamYoblick |
|
I have dotnet/windowsdesktop#531 and dotnet/windowsdesktop#532 submitted to absorb the channel addition break. Porting the PR I mentioned above (and any other involved changes) can be tracked separately to avoid this being a break in the future, I'll file an issue. |
This comment has been minimized.
This comment has been minimized.
|
Filed dotnet/windowsdesktop#533 to track the long term fix. |
This comment has been minimized.
This comment has been minimized.
|
This windowsdesktop build is now running with the fix: https://dev.azure.com/dnceng/internal/_build/results?buildId=530513&view=results |
This comment has been minimized.
This comment has been minimized.
…ld 20200220.3 - Microsoft.WindowsDesktop.App - 5.0.0-preview.1.20120.3 - Microsoft.WindowsDesktop.App.Ref - 5.0.0-preview.1.20120.3 - Microsoft.WindowsDesktop.App.Runtime.win-x64 - 5.0.0-preview.1.20120.3 Dependency coherency updates - Microsoft.Dotnet.WinForms.ProjectTemplates - 5.0.0-preview.1.20118.1 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64) - Microsoft.DotNet.Wpf.ProjectTemplates - 5.0.0-preview.1.20119.9 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)
|
Looks like the build got added to the channel before publishing completed. 🤦♂ The NuGet Validate stage failed with a funky AzDO error, I posted in the First Responder Teams about it and hit retry because it looks like it could be network flakiness. Keep an eye on https://dev.azure.com/dnceng/internal/_build/results?buildId=530513&view=results to see when to retry this PR. |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
|
@dagood the PR is green, are we good to go? |
Auto-Merge StatusThis pull request has been merged because the following merge policies have succeeded.
|
|
Never mind, the bot did it for us 😆 |
|
Thanks, all! |
This pull request updates the following dependencies
From https://github.com/dotnet/windowsdesktop
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format