Add channel for '.NET 5 Preview 1'#531
Merged
Merged
Conversation
dagood
force-pushed
the
add-5p1-channel
branch
from
c67123a to
da4b963
Compare
This was referenced Feb 20, 2020
Member
Author
|
Filed #533 for the followup to make this not necessary. |
Member
|
Will the next update from dotnet/arcade regress this? |
Member
Author
|
No, what's being maintained here is a mapping of Arcade channel IDs/names that's used to generate some extra stages in the windowsdesktop build. It's not changing eng/common or anything like that. A similar change will need to be done when new channels are added/removed in the future, unless #533 is done first. |
Member
Author
|
Merging to keep |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a channel mapping for new 5p1 channel. Adding/removing channels are breaking changes for dotnet/windowsdesktop until dotnet/core-setup#8426 and associated PRs are ported to dotnet/windowsdesktop. /cc @mmitche
I queued and canceled a very basic test build at https://dev.azure.com/dnceng/internal/_build/results?buildId=530465&view=results to see if template is valid.