Always mark Delegate types as instantiated#454
Merged
marek-safar merged 1 commit intoFeb 4, 2019
Merged
Conversation
marek-safar
requested changes
Feb 1, 2019
|
|
||
| protected virtual bool AlwaysMarkTypeAsInstantiated (TypeDefinition td) | ||
| { | ||
| switch (td.FullName) { |
Contributor
There was a problem hiding this comment.
FullName is expensive property, use name + namespace instead
mrvoorhe
force-pushed
the
master-always-mark-del-as-inst-possible
branch
from
c9a295b to
7273418
Compare
This was referenced Feb 1, 2019
Merged
Contributor
|
build |
marek-safar
reviewed
Feb 4, 2019
| /// <summary> | ||
| /// Delegate and is created from | ||
| /// </summary> | ||
| [SetupLinkerCoreAction ("link")] |
Contributor
There was a problem hiding this comment.
This will be problematic as the mscorlib will be used for execution.
Contributor
Author
There was a problem hiding this comment.
I don’t follow. Are you saying that it’s bad that this test is dependent on a particular mscorlib?
Contributor
There was a problem hiding this comment.
I am saying it won't be easy to run the test
Delegate and MulticastDelegate are instantiated from native code which causes us to not record that instances of these types could exist. As a result, today we remove the interfaces from Delegate. This doesn't seem to cause any issues, but it's probably not the greatest idea. In the future with base sweeping or uninstantiated type method stubbing, this lack of recording these types as instance possible causes bigger problems.
mrvoorhe
force-pushed
the
master-always-mark-del-as-inst-possible
branch
from
7273418 to
9a543b9
Compare
marek-safar
approved these changes
Feb 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delegate and MulticastDelegate are instantiated from native code which causes us to not record that instances of these types could exist. As a result, today we remove the interfaces from Delegate. Removing the interfaces doesn't seem to cause any issues today, but it's probably not the greatest idea.
In the future with base sweeping or uninstantiated type method stubbing, this lack of recording these types as instance possible causes bigger problems.