Override removal#456
Conversation
|
@marek-safar FYI for perspective this PR is not a particularly big size for a |
b4c1907 to
d7e3ef9
Compare
|
Fixed the test failure. I still need to check on the il2cpp test results w/ this change before I drop the |
d7e3ef9 to
0da49a6
Compare
|
@marek-safar This PR is ready for final review. After preserving the Do you want me to open a PR to mono master adding either of these |
|
Looks like after rebasing and picking up the Finalize() fix I have a couple test failures. I will take a look. |
0da49a6 to
655c2c3
Compare
|
Easy fix. Needed to update the |
If no instance of a type can exist, then it's safe to not mark overrides as long as the method being overridden is not abstract.
This change should be good to go. I've added
WIPas I'm still running these changes through our il2cpp test suite as that is a valuable way to get some extra coverage on linker changes.Do not land this branch before #454 otherwise there will be problems.