Kill all dotnet processes after build #1390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artidoro
changed the title
artidoro
changed the title
shauheen
approved these changes
Oct 26, 2018
eerhardt
reviewed
Oct 26, 2018
| call "%_dotnet%" "%_toolRuntime%\run.exe" "%_json%" %* | ||
|
|
||
| :: Terminate all dotnet build processes. | ||
| call "%_dotnet%" "build-server" "shutdown" |
Member
There was a problem hiding this comment.
This is not where I would expect this line to go.
For things like this (that only affect official build, or CI, etc), we should be modifying the official build and/or CI .yml files. This kind of change affects EVERYONE who tries building our repo - even devs on their own boxes. Killing the build server after each time I call "build" on the command line slows down my dev workflow because it needs to spin the build server up again the next time I call "build".
Contributor
Author
There was a problem hiding this comment.
Ok I will change that to the .yml file so that it only affects the official build.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1357.
As explained in more detail in the issue, a process must be leaking during one of the build jobs (the windows one), and is likely not terminating dotnet.exe. Subsequent attempts to clean the repo fail.
In this PR I implement the fix that is suggested in the issue: call dotnet build-server shutdown after the build process terminates.
I manually queued this change 10 times on VSTS, and the error that we were seeing has not appeared again. There 2 other errors that did show up 2 times, but seem to be unrelated to this.