Skip to content

Kill all dotnet processes after build #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artidoro merged 2 commits into from
Oct 26, 2018
Merged

Kill all dotnet processes after build #1390

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df15dfd
testing dotnet build-server shutdown
artidoro Oct 26, 2018
8dd2e85
revert run.sh changes and correct comment
artidoro Oct 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions run.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ set _json=%~dp0config.json

pushd "%~dp0"
call "%_dotnet%" "%_toolRuntime%\run.exe" "%_json%" %*

:: Terminate all dotnet build processes.
call "%_dotnet%" "build-server" "shutdown"
Copy link
Member

@eerhardt eerhardt Oct 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not where I would expect this line to go.

For things like this (that only affect official build, or CI, etc), we should be modifying the official build and/or CI .yml files. This kind of change affects EVERYONE who tries building our repo - even devs on their own boxes. Killing the build server after each time I call "build" on the command line slows down my dev workflow because it needs to spin the build server up again the next time I call "build".

Copy link
Contributor Author

@artidoro artidoro Oct 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I will change that to the .yml file so that it only affects the official build.

popd

exit /b %ERRORLEVEL%