Skip to content

Conversation

@rogancarr
Copy link
Contributor

  • Renaming OptimizationTolerance in LBFGS to fix a spelling bug.

* Renaming OptimizationTolerance in LBFGS to fix a spelling bug.

(cherry picked from commit 073a33b)
@rogancarr rogancarr requested review from eerhardt and shauheen April 5, 2019 22:34
@rogancarr
Copy link
Contributor Author

Request to cherry-pick 073a33bf8193256f2853b10a81417fce37523096 into the 1.0 release.

@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

❗ No coverage uploaded for pull request base (release/1.0@62a5b34). Click here to learn what that means.
The diff coverage is 92.99%.

@@              Coverage Diff               @@
##             release/1.0    #3225   +/-   ##
==============================================
  Coverage               ?   72.62%           
==============================================
  Files                  ?      807           
  Lines                  ?   145080           
  Branches               ?    16213           
==============================================
  Hits                   ?   105358           
  Misses                 ?    35304           
  Partials               ?     4418
Flag Coverage Δ
#Debug 72.62% <92.99%> (?)
#production 68.16% <79.7%> (?)
#test 88.92% <98.9%> (?)
Impacted Files Coverage Δ
src/Microsoft.ML.Data/Transforms/Normalizer.cs 86.03% <ø> (ø)
...osoft.ML.TimeSeries.StaticPipe/TimeSeriesStatic.cs 100% <ø> (ø)
...LogisticRegression/MulticlassLogisticRegression.cs 67.61% <ø> (ø)
...oft.ML.StandardTrainers/StandardTrainersCatalog.cs 92.34% <ø> (ø)
src/Microsoft.ML.Transforms/CategoricalCatalog.cs 68.42% <ø> (ø)
...s/Scenarios/Api/CookbookSamples/CookbookSamples.cs 99.49% <ø> (ø)
...osoft.ML.Recommender/MatrixFactorizationTrainer.cs 70.39% <ø> (ø)
...Microsoft.ML.Transforms/FeatureSelectionCatalog.cs 60% <ø> (ø)
...c/Microsoft.ML.ImageAnalytics/ExtensionsCatalog.cs 16.66% <ø> (ø)
...oft.ML.Recommender/MatrixFactorizationPredictor.cs 86.21% <ø> (ø)
... and 38 more

Copy link
Contributor

@shauheen shauheen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shauheen shauheen added this to the 0419 milestone Apr 9, 2019
@shauheen
Copy link
Contributor

Done as part of #3333 . Thanks @rogancarr

@shauheen shauheen closed this Apr 14, 2019
@rogancarr rogancarr deleted the 3198_to_release branch April 15, 2019 16:30
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants