Skip to content

[msbuild] Bump Xamarin.MacDev and use AppleSdkVersion instead of MacOSXSdkVersion/IPhoneSdkVersion. #10622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rolfbjarne merged 1 commit into from
Feb 12, 2021
Merged

[msbuild] Bump Xamarin.MacDev and use AppleSdkVersion instead of MacOSXSdkVersion/IPhoneSdkVersion. #10622

rolfbjarne merged 1 commit into from
Feb 12, 2021

Conversation

@rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Feb 11, 2021

This requires bumping Xamarin.MacDev.

New commits in xamarin/Xamarin.MacDev:

Diff: https://github.com/xamarin/Xamarin.MacDev/compare/fae0237704b792004adf592d8c9038a9d46aafff..02d6d05be3506c89a3b4fa8a8ceb7f33712a8f46

@rolfbjarne
[msbuild] Bump Xamarin.MacDev and use AppleSdkVersion instead of MacO…
6519183 
…SXSdkVersion/IPhoneSdkVersion.

This requires bumping Xamarin.MacDev.

New commits in xamarin/Xamarin.MacDev:

* dotnet/macios-devtools@02d6d05 [Xamarin.MacDev] Add an AppleSdkVersion struct which replaces IPhoneSdkVersion and MacOSXSdkVersion. (dotnet#87)
* dotnet/macios-devtools@e7ec7ef [Xamarin.MacDev] Fail gracefully if trying to grab a PList entry from a file that doesn't exist. (dotnet#86)

Diff: https://github.com/xamarin/Xamarin.MacDev/compare/fae0237704b792004adf592d8c9038a9d46aafff..02d6d05be3506c89a3b4fa8a8ceb7f33712a8f46
@rolfbjarne rolfbjarne requested a review from emaf as a code owner February 11, 2021 15:16
@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label Feb 11, 2021
@mandel-macaque mandel-macaque added not-notes-worthy Ignore for release notes and removed not-notes-worthy Ignore for release notes labels Feb 11, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Feb 11, 2021

❌ Tests failed on Build ❌

Tests failed on Build.

Test results

1 tests failed, 180 tests passed.

Failed tests

  • introspection/watchOS 32-bits - simulator/Debug (watchOS 3.2): LaunchFailure Known issue: HE0038)

Pipeline on Agent XAMBOT-1094'

@rolfbjarne
Copy link
Member Author

rolfbjarne commented Feb 12, 2021

Test failure is unrelated (#10236).

@rolfbjarne rolfbjarne merged commit c3677a0 into dotnet:main Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@emaf emaf emaf approved these changes

+2 more reviewers

@spouliot spouliot spouliot approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

not-notes-worthy Ignore for release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @spouliot @mandel-macaque @emaf