[msbuild] Make sure CFBundleShortVersionString is set to something. #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the watch from getting mightily confused when re-installing watch apps/extensions. Not having a CFBundleShortVersionString would cause the following: * Build & install & run would work fine the first time. * The second build & install would confuse the watch so that the app wouldn't launch. Removing the app and reinstalling wouldn't work; the potential options would be to either reboot the device, or add a CFBundleShortVersionString to the Info.plists and install that build twice.
Collaborator
|
Build success |
rolfbjarne
added a commit
that referenced
this pull request
Aug 4, 2020
New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@d7f55a6 [TouchRunner] Add support for a --test:<testname> argument to select a specific test to run. (#85) * xamarin/Touch.Unit@6cf8d0b [TouchRunner] Fix test filtering. (#86) * xamarin/Touch.Unit@c4a1cd1 [TouchRunner] The mac runner must run tests inside NSApplication.Run. (#84) Diff: https://github.com/spouliot/Touch.Unit/compare/f62066880ae548bac9302d714b8c045955051014..d7f55a61673e18ae5a8f9628600081a54b4e074c
mandel-macaque
pushed a commit
to mandel-macaque/xamarin-macios
that referenced
this pull request
Nov 12, 2020
New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@d7f55a6 [TouchRunner] Add support for a --test:<testname> argument to select a specific test to run. (dotnet#85) * xamarin/Touch.Unit@6cf8d0b [TouchRunner] Fix test filtering. (dotnet#86) * xamarin/Touch.Unit@c4a1cd1 [TouchRunner] The mac runner must run tests inside NSApplication.Run. (dotnet#84) Diff: https://github.com/spouliot/Touch.Unit/compare/f62066880ae548bac9302d714b8c045955051014..d7f55a61673e18ae5a8f9628600081a54b4e074c
rolfbjarne
added a commit
to rolfbjarne/macios
that referenced
this pull request
Feb 11, 2021
…SXSdkVersion/IPhoneSdkVersion. This requires bumping Xamarin.MacDev. New commits in xamarin/Xamarin.MacDev: * dotnet/macios-devtools@02d6d05 [Xamarin.MacDev] Add an AppleSdkVersion struct which replaces IPhoneSdkVersion and MacOSXSdkVersion. (dotnet#87) * dotnet/macios-devtools@e7ec7ef [Xamarin.MacDev] Fail gracefully if trying to grab a PList entry from a file that doesn't exist. (dotnet#86) Diff: https://github.com/xamarin/Xamarin.MacDev/compare/fae0237704b792004adf592d8c9038a9d46aafff..02d6d05be3506c89a3b4fa8a8ceb7f33712a8f46
rolfbjarne
added a commit
that referenced
this pull request
Feb 12, 2021
…SXSdkVersion/IPhoneSdkVersion. (#10622) This requires bumping Xamarin.MacDev. New commits in xamarin/Xamarin.MacDev: * dotnet/macios-devtools@02d6d05 [Xamarin.MacDev] Add an AppleSdkVersion struct which replaces IPhoneSdkVersion and MacOSXSdkVersion. (#87) * dotnet/macios-devtools@e7ec7ef [Xamarin.MacDev] Fail gracefully if trying to grab a PList entry from a file that doesn't exist. (#86) Diff: https://github.com/xamarin/Xamarin.MacDev/compare/fae0237704b792004adf592d8c9038a9d46aafff..02d6d05be3506c89a3b4fa8a8ceb7f33712a8f46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the watch from getting mightily confused when re-installing
watch apps/extensions.
Not having a CFBundleShortVersionString would cause the following:
app wouldn't launch. Removing the app and reinstalling wouldn't
work; the potential options would be to either reboot the device,
or add a CFBundleShortVersionString to the Info.plists and install
that build twice.