[AppKit] Remove the NS[Open|Save]Panel constructors in XAMCORE_5_0. Fixes #6474. by rolfbjarne · Pull Request #21346 · dotnet/macios

rolfbjarne · 2024-10-01T10:32:59Z

These constructors haven't worked since macOS 10.14 (see #6474), so just
remove them (when we can make breaking changes).

Fixes #6474.

…ixes #6474. These constructors haven't worked since macOS 10.14 (see #6474), so just remove them (when we can make breaking changes). Fixes #6474.

vs-mobiletools-engineering-service2 · 2024-10-01T11:52:28Z

📚 [CI Build] Artifacts 📚

Artifacts were not provided.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-10-01T12:03:57Z

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: e37f04fb84848025f689e7876cf2e5354cd559c1 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-01T12:17:01Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: e37f04fb84848025f689e7876cf2e5354cd559c1 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-01T16:11:09Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: e37f04fb84848025f689e7876cf2e5354cd559c1 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-01T16:15:36Z

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11) passed.

Pipeline on Agent
Hash: e37f04fb84848025f689e7876cf2e5354cd559c1 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-01T16:16:50Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: e37f04fb84848025f689e7876cf2e5354cd559c1 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-01T16:18:05Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: e37f04fb84848025f689e7876cf2e5354cd559c1 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-01T16:20:11Z

✅ API diff for current PR / commit

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: e37f04fb84848025f689e7876cf2e5354cd559c1 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-01T19:14:19Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

6 tests crashed, 1 tests failed, 34 tests passed.

Failures

❌ cecil tests

1 tests failed, 0 tests passed.

Details

Cecil-based tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ generator tests

🔥 Failed catastrophically on VSTS: test results - generator (no summary found).

Html Report (VSDrops) Download

❌ interdependent-binding-projects tests

🔥 Failed catastrophically on VSTS: test results - interdependent-binding-projects (no summary found).

Html Report (VSDrops) Download

❌ linker tests

🔥 Failed catastrophically on VSTS: test results - linker (no summary found).

Html Report (VSDrops) Download

❌ monotouch tests (macOS)

🔥 Failed catastrophically on VSTS: test results - monotouch_macos (no summary found).

Html Report (VSDrops) Download

❌ monotouch tests (tvOS)

🔥 Failed catastrophically on VSTS: test results - monotouch_tvos (no summary found).

Html Report (VSDrops) Download

❌ msbuild tests

🔥 Failed catastrophically on VSTS: test results - msbuild (no summary found).

Html Report (VSDrops) Download

Successes

✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 7 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: e37f04fb84848025f689e7876cf2e5354cd559c1 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-02T19:20:41Z

📚 [CI Build] Artifacts 📚

Artifacts were not provided.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-10-02T19:21:30Z

✅ API diff for current PR / commit

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: fedd2f06ecb50a1d280b9b5522e7fbd49a3bdcd2 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-02T19:29:36Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: fedd2f06ecb50a1d280b9b5522e7fbd49a3bdcd2 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-02T19:32:45Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: fedd2f06ecb50a1d280b9b5522e7fbd49a3bdcd2 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-02T19:36:35Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: fedd2f06ecb50a1d280b9b5522e7fbd49a3bdcd2 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-02T19:43:53Z

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11) passed.

Pipeline on Agent
Hash: fedd2f06ecb50a1d280b9b5522e7fbd49a3bdcd2 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-02T20:44:57Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: fedd2f06ecb50a1d280b9b5522e7fbd49a3bdcd2 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-03T08:56:43Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 97 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (iOS): All 7 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 7 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (macOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 7 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download

Pipeline on Agent
Hash: fedd2f06ecb50a1d280b9b5522e7fbd49a3bdcd2 [PR build]

[AppKit] Remove the NS[Open|Save]Panel constructors in XAMCORE_5_0. F…

e37f04f

…ixes #6474. These constructors haven't worked since macOS 10.14 (see #6474), so just remove them (when we can make breaking changes). Fixes #6474.

rolfbjarne requested a review from dalexsoto as a code owner October 1, 2024 10:33

stephen-hawley approved these changes Oct 1, 2024

View reviewed changes

dalexsoto approved these changes Oct 1, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

haritha-mohan approved these changes Oct 2, 2024

View reviewed changes

Update cecil tests.

6b128c3

mandel-macaque approved these changes Oct 2, 2024

View reviewed changes

mcumming approved these changes Oct 2, 2024

View reviewed changes

Merge branch 'main' into dev/rolf/remove-nsopensavepanel-ctors

fedd2f0

This comment has been minimized.

Sign in to view

rolfbjarne merged commit 260b12a into main Oct 3, 2024

rolfbjarne deleted the dev/rolf/remove-nsopensavepanel-ctors branch October 3, 2024 09:13

Conversation

rolfbjarne commented Oct 1, 2024

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 1, 2024

📚 [CI Build] Artifacts 📚

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 1, 2024

❌ [CI Build] Windows Integration Tests failed ❌

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 1, 2024

💻 [CI Build] Windows Integration Tests passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 1, 2024

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 1, 2024

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 1, 2024

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 1, 2024

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 1, 2024

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 1, 2024

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ cecil tests

❌ generator tests

❌ interdependent-binding-projects tests

❌ linker tests

❌ monotouch tests (macOS)

❌ monotouch tests (tvOS)

❌ msbuild tests

Successes

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 2, 2024

📚 [CI Build] Artifacts 📚

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 2, 2024

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 2, 2024

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 2, 2024

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 2, 2024

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 2, 2024

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 2, 2024

💻 [CI Build] Windows Integration Tests passed 💻

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 3, 2024

🚀 [CI Build] Test results 🚀

Test results

Tests counts

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!