Skip to content

[AppKit] Remove the NS[Open|Save]Panel constructors in XAMCORE_5_0. Fixes #6474. #21346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 3 commits into from
Oct 3, 2024
Merged

[AppKit] Remove the NS[Open|Save]Panel constructors in XAMCORE_5_0. Fixes #6474. #21346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e37f04f
[AppKit] Remove the NS[Open|Save]Panel constructors in XAMCORE_5_0. F…
rolfbjarne Oct 1, 2024
6b128c3
Update cecil tests.
rolfbjarne Oct 2, 2024
fedd2f0
Merge branch 'main' into dev/rolf/remove-nsopensavepanel-ctors
rolfbjarne Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/appkit.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9307,10 +9307,13 @@ interface NSOpenPanel {
[ForcedType] // different type used inside a sandbox
NSOpenPanel OpenPanel { get; }

#if !XAMCORE_5_0
[EditorBrowsable (EditorBrowsableState.Never)]
[Advice ("You must use 'OpenPanel' method if the application is sandboxed.")]
[Deprecated (PlatformName.MacOSX, 10, 15, message: "All open panels now run out-of-process, use 'OpenPanel' method instead")]
[Export ("init")]
NativeHandle Constructor ();
#endif

[Export ("URLs")]
NSUrl [] Urls { get; }
Expand Down Expand Up @@ -13652,10 +13655,13 @@ interface NSSavePanel {
[ForcedType] // different type used inside a sandbox
NSSavePanel SavePanel { get; }

#if !XAMCORE_5_0
[Advice ("You must use 'SavePanel' method if the application is sandboxed.")]
[Deprecated (PlatformName.MacOSX, 10, 15, message: "All save panels now run out-of-process, use 'SavePanel' method instead")]
[EditorBrowsable (EditorBrowsableState.Never)]
[Export ("init")]
NativeHandle Constructor ();
#endif

[Export ("URL")]
NSUrl Url { get; }
Expand Down
2 changes: 0 additions & 2 deletions tests/cecil-tests/Documentation.KnownFailures.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24342,7 +24342,6 @@ M:AppKit.NSOpenGLPixelFormat.#ctor(System.Object[])
M:AppKit.NSOpenGLPixelFormat.#ctor(System.UInt32[])
M:AppKit.NSOpenGLPixelFormat.EncodeTo(Foundation.NSCoder)
M:AppKit.NSOpenGLView.#ctor(CoreGraphics.CGRect)
M:AppKit.NSOpenPanel.#ctor
M:AppKit.NSOpenPanel.BeginSheet(System.String,System.String,System.String[],AppKit.NSWindow,System.Action)
M:AppKit.NSOpenPanel.BeginSheet(System.String,System.String,System.String[],AppKit.NSWindow)
M:AppKit.NSOpenSaveExpandingEventArgs.#ctor(System.Boolean)
Expand Down Expand Up @@ -24687,7 +24686,6 @@ M:AppKit.NSRulerMarkerClientViewDelegation.RulerViewLocation(AppKit.NSView,AppKi
M:AppKit.NSRulerMarkerClientViewDelegation.RulerViewPoint(AppKit.NSView,AppKit.NSRulerView,System.Runtime.InteropServices.NFloat)
M:AppKit.NSRulerView.#ctor(CoreGraphics.CGRect)
M:AppKit.NSRulerView.Dispose(System.Boolean)
M:AppKit.NSSavePanel.#ctor
M:AppKit.NSSavePanel.add_DidChangeToDirectory(System.EventHandler{AppKit.NSOpenSavePanelUrlEventArgs})
M:AppKit.NSSavePanel.add_DidSelectType(System.EventHandler{AppKit.NSopenSavePanelUTTypeEventArgs})
M:AppKit.NSSavePanel.add_DirectoryDidChange(System.EventHandler{AppKit.NSOpenSaveFilenameEventArgs})
Expand Down