Skip to content

Conversation

@rolfbjarne
Copy link
Member

No description provided.

rolfbjarne and others added 30 commits May 13, 2025 10:44
This way CI for localization PRs is automatically started correctly.
This pull request updates the following dependencies

## From https://github.com/dotnet/xharness

- **Subscription**: [02e03784-16b3-4ced-b02a-3715797fc7da](https://maestro.dot.net/subscriptions?search=02e03784-16b3-4ced-b02a-3715797fc7da)
- **Build**: [20250512.1](https://dev.azure.com/dnceng/internal/_build/results?buildId=2707289)
- **Date Produced**: May 12, 2025 9:33:40 AM UTC
- **Commit**: [173a357c9d49136d9b7d49ca2bf9709a68067e19](dotnet/xharness@173a357)
- **Branch**: refs/heads/main

- **Updates**:
  - **Microsoft.DotNet.XHarness.iOS.Shared**: [from 10.0.0-prerelease.25255.1 to 10.0.0-prerelease.25262.1][1]

[1]: dotnet/xharness@e85bb14...173a357
…#22764)

Add a factory method that will generate the argument syntax for the
parameters to be used in the delegate call within a trampoline.

---------

Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
…2789)

There are a number of parameters that required a number of conversions
pre and post executing a delegate from a trampoline. This commit adds
support for that scenario in those parameters that are by ref.

---------

Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
)

* Fix availability for the SampleCount property.
* Fix the [Horizontal|Vertical]SampleStorage properties to actually work by marshalling
  a float array instead of double array.
* Add tests.
Retrieve the call for the deleate of a trampoline. The statment will
have the variable assigment when needed.

---------

Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
It will end up throwing an exception, and it will just make the build log a
whole lot more confusing.
App Extensions on Mac Catalyst go where they do for macOS: inside the
Contents/ directory.
Run the 'Fetch remote binlogs' after 'Fail if test failures', because the
'Fetch remote binlogs' step is not required to pass, but if it fails before
'Fail if test failures', it will be treated as a test failure and the job will
fail.
This pull request updates the following dependencies

## From https://github.com/dotnet/arcade

- **Subscription**: [0ed7aa82-fff7-4048-943c-7b5fa7eed6f0](https://maestro.dot.net/subscriptions?search=0ed7aa82-fff7-4048-943c-7b5fa7eed6f0)
- **Build**: [20250513.5](https://dev.azure.com/dnceng/internal/_build/results?buildId=2708585)
- **Date Produced**: May 14, 2025 12:31:08 AM UTC
- **Commit**: [93823d49ca01742464ad1c0b49ea940e693b1be3](dotnet/arcade@93823d4)
- **Branch**: refs/heads/release/9.0

- **Updates**:
  - **Microsoft.DotNet.Arcade.Sdk**: [from 9.0.0-beta.25255.5 to 9.0.0-beta.25263.5][1]
  - **Microsoft.DotNet.Build.Tasks.Feed**: [from 9.0.0-beta.25255.5 to 9.0.0-beta.25263.5][1]

[1]: dotnet/arcade@1cfa39f...93823d4

- **Updates to .NET SDKs:**
  - Updates sdk.version to 9.0.106
  - Updates tools.dotnet to 9.0.106

---------

Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
…1: Build ID 11605235 (#22822)

This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.

---------
…1: Build ID 11603789 (#22815)

This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.

---------
…1: Build ID 11605223 (#22821)

This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.

---------
This pull request updates the following dependencies

## From https://github.com/dotnet/arcade

- **Subscription**: [0ed7aa82-fff7-4048-943c-7b5fa7eed6f0](https://maestro.dot.net/subscriptions?search=0ed7aa82-fff7-4048-943c-7b5fa7eed6f0)
- **Build**: [20250516.2](https://dev.azure.com/dnceng/internal/_build/results?buildId=2711101)
- **Date Produced**: May 16, 2025 10:30:49 PM UTC
- **Commit**: [c62eeb5b5432f9eaa034fbd641ccd9fd0d928fb3](dotnet/arcade@c62eeb5)
- **Branch**: refs/heads/release/9.0

- **Updates**:
  - **Microsoft.DotNet.Arcade.Sdk**: [from 9.0.0-beta.25263.5 to 9.0.0-beta.25266.2][1]
  - **Microsoft.DotNet.Build.Tasks.Feed**: [from 9.0.0-beta.25263.5 to 9.0.0-beta.25266.2][1]

[1]: dotnet/arcade@93823d4...c62eeb5

- **Updates to .NET SDKs:**
  - Updates sdk.version to 9.0.106
  - Updates tools.dotnet to 9.0.106
…endingNotificationRequests's response. (#22833)

Headers and documentation says `null` won't be returned here, but empirical
evidence from customers say otherwise: #22786, so honor that instead.

Unfortunately this is currently a breaking change, so it will only be changed for XAMCORE_5_0.

Fixes #22786.
* Add an MSBuild target to validate the required Xcode version.
	* Our previous error logic is in a custom linker step, and as such runs
	  much later in the build process. This way shows the error to the user
	  much sooner. The fact that it's in a custom linker step also makes it
	  harder to show a good error experience.

* Use a different message than previous error messages, which will hopefully
  be a bit more helpful and accurate. Also point to an online help document
  that explains the possible solution(s).

Partial fix for #22750.
…ampoline. (#22834)

Add a new method that will take a managed delegate parameter and will
generate the needed parameter syntax for the Invoke and delegate in a
trampoline.

Example of conversions:

Action -> IntrPtr
NSObject -> NativeHandle
Pointer -> Pointer
Array -> NativeHandle

The tests take care to verify that the correct conversions is done for
all the known parameter types.

We need this conversion to fix the reviews in
#22813

---------

Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
…1: Build ID 11622326 (#22853)

This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.

---------
Continuation of #19003

This means the linker will remove either `CFNetworkHandler` or `NSUrlSessionHandler` depending on which is chosen at build time (or both, if neither is chosen).

This will shrink app size a little bit, here are the types and members that are no longer included when using `NSUrlSessionHandler`: https://gist.github.com/rolfbjarne/102d77d5f105a7c98ac6be19de725dd5

A very basic app is ~55kb / 0.2% smaller: https://gist.github.com/rolfbjarne/a1cb6898aa560f0a891286be20b9bc3e

Fixes #14298.

---------

Co-authored-by: Agnik Bakshi <77234005+Agnik7@users.noreply.github.com>
Co-authored-by: Dustin Wojciechowski <dustin.wojciechowski@microsoft.com>
Co-authored-by: Michael Cummings <mcumming@microsoft.com>
Co-authored-by: Alex Soto <alex@soto.dev>
…mpoline. (#22813)

The delegate must use the name provided by the Nomenclator, have the
first parameter as a IntPtr to the block and then all the other
parameters from the delegate. The return type should be the same as the
original parameter.

---------

Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
…LNoiseTexture slightly. (#22844)

Improve and simplify the manually bound constructors for MDLNoiseTexture by
using the same pattern we use elsewhere for manually bound constructors.
* Add/adjust availability attributes.
* Remove !.NET availability attributes / code.

This is a step towards fixing #21185.
@vs-mobiletools-engineering-service2

This comment has been minimized.

mandel-macaque and others added 5 commits May 26, 2025 21:02
There are 3 things to focus on:

1. Ensure the correct argument name is used if a conversion is needed.
2. If no conversion is needed use ByRef
3. Ensure we use the correct ref kind token.

New tests added and old updated.

---------

Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
…#22894)

The code was not creating a pointer declaration when the type was not
nullable because we were missing a switch option.

Updated the way we generate the pointer in a more generic way by calling
the GetLowerMethod which will work for all possible types.

---------

Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
Ensure that the name of a nested class is "Parent.Class" and its
namespace is that of the parent.

The previous algorithm was mixing the parent name class and the
namespace which would be problematic when we want to import the
namespace from a TypeInfo.

---------

Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
* Add/adjust availability attributes.
* Ignore availability warnings in a couple of places.
* Remove !.NET availability attributes / code.

This is a step towards fixing #21185.
…e encodings. Fixes #22837. (#22859)

Fix skipping consecutive nested structs (such as `"{CGPoint=dd}{CGSize=dd}"` inside `"{CGRect={CGPoint=dd}{CGSize=dd}}"`) by keep looping once the first nested struct is found.

Fixes #22837.
…22906)

Store the non-file inputs to the AOT compiler in a cache file, and if these inputs
change, then clean the entire cache of AOT-compiled output. This is implemented by
computing a hash of all these inputs (properties), store the hash to a file, and
overwrite the file if the hash changes. Then in a subsequent target, we wipe the
AOT compiler cache if the file with the hash value changed.

This is a similar implementation of how the csc task (C# compiler) creates a hash
of the compiler input in order to know when to re-execute the C# compiler.

Fixes #21061.
#19242. (#22882)

* Add support for a 'CodesignEntitlements' metadata to the 'AdditionalAppExtensions' item group, to make it easier to specify the entitlements for such an app extension.
* Warn if no entitlements are set for app extensions in 'AdditionalAppExtensions' items.

Fixes #19242.
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #0affd4b] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 0affd4b494f2c2f762ba189cae9ab5eff92ce944 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #0affd4b] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 0affd4b494f2c2f762ba189cae9ab5eff92ce944 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 0affd4b494f2c2f762ba189cae9ab5eff92ce944 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #0affd4b] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 0affd4b494f2c2f762ba189cae9ab5eff92ce944 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #0affd4b] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 0affd4b494f2c2f762ba189cae9ab5eff92ce944 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #0affd4b] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 0affd4b494f2c2f762ba189cae9ab5eff92ce944 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #0affd4b] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 0affd4b494f2c2f762ba189cae9ab5eff92ce944 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #0affd4b] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 0affd4b494f2c2f762ba189cae9ab5eff92ce944 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

1 similar comment
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build #0affd4b] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

1 tests crashed, 0 tests failed, 112 tests passed.

Failures

❌ windows tests

🔥 Failed catastrophically on VSTS: test results - windows (no summary found).

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 0affd4b494f2c2f762ba189cae9ab5eff92ce944 [PR build]

@rolfbjarne
Copy link
Member Author

Windows test failure is due to dotnet/macios-devtools#133.

@rolfbjarne rolfbjarne merged commit 252bf19 into xcode16.4 May 29, 2025
41 of 44 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/bump-main-in-xcode16.4-2025-05-26 branch May 29, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants