Ensure UrlSession is cleaned up on dispose#24377
Closed
dotMorten wants to merge 2 commits intodotnet:mainfrom
Closed
Ensure UrlSession is cleaned up on dispose#24377dotMorten wants to merge 2 commits intodotnet:mainfrom
dotMorten wants to merge 2 commits intodotnet:mainfrom
Conversation
rolfbjarne
reviewed
Dec 8, 2025
| configuration.HttpCookieStorage = null; | ||
| } | ||
| session = NSUrlSession.FromConfiguration (configuration, (INSUrlSessionDelegate) new NSUrlSessionHandlerDelegate (this), null); | ||
| oldSession.FinishTasksAndInvalidate (); |
Member
There was a problem hiding this comment.
I don't think this is needed, because at the beginning in this setter we make sure there have been no requests made yet (so there are no tasks that need to finish):
macios/src/Foundation/NSUrlSessionHandler.cs
Line 423 in 39e0d68
Member
|
I'll have a look and see if I can reproduce this and create a test! |
Member
|
Closing in favor of #24384 (because our CI won't work with PRs from forks). |
rolfbjarne
added a commit
that referenced
this pull request
Dec 9, 2025
…spose. (#24384) Fixes #24376 Doc references: - https://developer.apple.com/documentation/foundation/urlsession/invalidateandcancel() - https://developer.apple.com/documentation/foundation/urlsession/finishtasksandinvalidate() Continuation of #24377 by @dotMorten. --------- Co-authored-by: Morten Nielsen <mn@iter.dk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24376
Doc references: