Skip to content

[Foundation] Ensure NSUrlSessionHandler's session is cleaned up on dispose. Fixes #24376.#24384

Merged
rolfbjarne merged 4 commits intomainfrom
dev/rolf/issue-24376
Dec 9, 2025
Merged

[Foundation] Ensure NSUrlSessionHandler's session is cleaned up on dispose. Fixes #24376.#24384
rolfbjarne merged 4 commits intomainfrom
dev/rolf/issue-24376

Conversation

@rolfbjarne
Copy link
Copy Markdown
Member

@rolfbjarne rolfbjarne commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes issue #24376 by ensuring that NSUrlSessionHandler properly invalidates its underlying NSUrlSession when disposed. The fix adds a call to InvalidateAndCancel() in the Dispose method, which is critical for background sessions that need to be properly cleaned up to allow the same session identifier to be reused.

  • Adds session.InvalidateAndCancel() call in the Dispose method
  • Includes a comprehensive test verifying background session handlers can be disposed and recreated with the same identifier

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/Foundation/NSUrlSessionHandler.cs Adds InvalidateAndCancel() call in the Dispose method to properly clean up the session
tests/monotouch-test/System.Net.Http/NSUrlSessionHandlerTest.cs New test file with test case verifying background session cleanup and recreation works correctly

Comment thread src/Foundation/NSUrlSessionHandler.cs
Comment thread tests/monotouch-test/System.Net.Http/NSUrlSessionHandlerTest.cs
@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [CI Build #60a35a0] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 60a35a08a7f22d9bbde2622920a8dba7ead25126 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [PR Build #60a35a0] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 60a35a08a7f22d9bbde2622920a8dba7ead25126 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 60a35a08a7f22d9bbde2622920a8dba7ead25126 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [CI Build #60a35a0] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 60a35a08a7f22d9bbde2622920a8dba7ead25126 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

💻 [CI Build #60a35a0] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 60a35a08a7f22d9bbde2622920a8dba7ead25126 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

💻 [CI Build #60a35a0] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 60a35a08a7f22d9bbde2622920a8dba7ead25126 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

💻 [CI Build #60a35a0] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 60a35a08a7f22d9bbde2622920a8dba7ead25126 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

💻 [CI Build #60a35a0] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 60a35a08a7f22d9bbde2622920a8dba7ead25126 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

💻 [CI Build #60a35a0] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 60a35a08a7f22d9bbde2622920a8dba7ead25126 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne rolfbjarne added the community Community contribution ❤ label Dec 8, 2025
@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

🚀 [CI Build #60a35a0] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 121 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 60a35a08a7f22d9bbde2622920a8dba7ead25126 [PR build]

@rolfbjarne rolfbjarne changed the title [Foundation] Ensure NSUrlSessionHandler's session is cleaned up on dispose. [Foundation] Ensure NSUrlSessionHandler's session is cleaned up on dispose. Fixes #24376. Dec 9, 2025
@rolfbjarne rolfbjarne merged commit 0618d77 into main Dec 9, 2025
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Community contribution ❤

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NSUrlSessionHandler.Dispose doesn't fully clean up

5 participants