Skip to content

[tests] Fix flaky TestNSUrlSessionHandlerSendClientCertificate. Fixes #25240 #25258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 1 commit into from
Apr 30, 2026
Merged

[tests] Fix flaky TestNSUrlSessionHandlerSendClientCertificate. Fixes #25240 #25258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/monotouch-test/System.Net.Http/MessageHandlers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,6 +703,7 @@ public void TestNSUrlSessionHandlerSendClientCertificate ()
if (!done) { // timeouts happen in the bots due to dns issues, connection issues etc.. we do not want to fail
Assert.Inconclusive ("Request timedout.");
} else {
TestRuntime.IgnoreInCIIfBadNetwork (ex);
Assert.IsNull (ex, "Exception wasn't expected.");
X509Certificate2 certificate2 = X509CertificateLoader.LoadCertificate (global::System.Convert.FromBase64String (content));
Assert.AreEqual (certificate.Thumbprint, certificate2.Thumbprint);
Expand Down
2 changes: 1 addition & 1 deletion tests/monotouch-test/System.Net.Http/NetworkResources.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public static class NetworkResources {
public static string XamarinHttpUrl => AssertNetworkConnection ("http://dotnet.microsoft.com/apps/xamarin");
public static Uri XamarinUri => new Uri (XamarinUrl);
public static string StatsUrl => AssertNetworkConnection ("https://api.imgur.com/2/stats");
public static string EchoClientCertificateUrl = "https://corefx-net-tls.azurewebsites.net/EchoClientCertificate.ashx";
public static string EchoClientCertificateUrl => AssertNetworkConnection ("https://corefx-net-tls.azurewebsites.net/EchoClientCertificate.ashx");

public static string [] HttpsUrls => new [] {
MicrosoftUrl,
Expand Down
Loading