Bump to mono:2019-02 #5563

directhex · 2019-02-06T15:10:55Z

No description provided.

spouliot · 2019-02-13T19:44:09Z

16:59:25 Undefined symbols for architecture armv7:
16:59:25   "_deflate", referenced from:
16:59:25       _CloseZStream in libmonoruntime_support_la-zlib-helper.o
16:59:25       _Flush in libmonoruntime_support_la-zlib-helper.o
16:59:25       _WriteZStream in libmonoruntime_support_la-zlib-helper.o
16:59:25   "_deflateEnd", referenced from:
16:59:25       _CloseZStream in libmonoruntime_support_la-zlib-helper.o
16:59:25   "_deflateInit2_", referenced from:
16:59:25       _CreateZStream in libmonoruntime_support_la-zlib-helper.o
16:59:25   "_inflate", referenced from:
16:59:25       _ReadZStream in libmonoruntime_support_la-zlib-helper.o
16:59:25      (maybe you meant: _mono_metadata_free_inflated_signature, _mono_metadata_get_inflated_signature , _mono_class_get_and_inflate_typespec_checked , _mono_get_inflated_method , _mono_class_inflate_generic_method , _mono_class_inflate_generic_type , _mono_class_inflate_generic_method_checked , _mono_inflate_generic_signature , _mono_class_inflate_generic_class_checked , _mono_class_inflate_generic_method_full_checked , _mono_metadata_inflate_generic_inst , _mono_class_get_inflated_method , _mono_inflated_methods_size , _mono_class_inflate_generic_type_with_mempool , _mono_class_inflate_generic_type_checked )
16:59:25   "_inflateEnd", referenced from:
16:59:25       _CloseZStream in libmonoruntime_support_la-zlib-helper.o
16:59:25   "_inflateInit2_", referenced from:
16:59:25       _CreateZStream in libmonoruntime_support_la-zlib-helper.o
16:59:25   CC       map.lo
16:59:25 ld: symbol(s) not found for architecture armv7
16:59:25 clang: error: linker command failed with exit code 1 (use -v to see invocation)
16:59:25 
make[1]: *** [/Users/builder/jenkins/workspace/xamarin-macios-pr-builder/builds/install/target7/tmp-lib/libmonosgen-2.0.dylib] Error 1

rolfbjarne · 2019-02-14T06:15:29Z

16:59:25 Undefined symbols for architecture armv7:

I believe those are fixed in the 2018-10 branch/PR.

Commit list for mono/mono: * mono/mono@c8906bed284 [corlib] Disable ThreadPoolTest.GetAvailableThreads () on machines with many cores * mono/mono@e21641dab1c [crash] Detect when 0 attached threads, fix hang/double-fault. * mono/mono@8ebb772f86d [2019-02] Bump bockbuild to get GTK fix * mono/mono@db0df0733d2 Ensure that the module cctor is run before the entry point is executed (#13242) (#13299) * mono/mono@1e36288b8e6 [jit] Avoid an assert when gsharedvt enums are boxed. (#13306) * mono/mono@4a0e34d3586 [2019-02] [linker] Fix monotouch tests which need Xamarin.iOS.dll (#13294) * mono/mono@c7e155b4a7f [2019-02] Fix mono conc hashtable lookup endless loop (#13291) * mono/mono@58faa215f47 [2019-02] [interp] mixed mode fixes for delegates (#13259) * mono/mono@43409aab03a [2019-02] Fix Directory.GetLogicalDrives () (#13286) * mono/mono@c3b2368aff0 [mini] Inline Selector.GetHandle for tvOS and watchOS assemblies as well. (#13254) * mono/mono@ce536b347bb [2019-02] [aot] add wrappers to \u0022slim\u0022 mscorlib (i.e. --aot=interp) (#13168) * mono/mono@5c6441aca83 [interp] compute size of generic valuetype correctly (#13226) * mono/mono@6ad7d7987d5 [sdks] Use throttle() instead of lock() * mono/mono@b5a53bf43ab Revert "[sdks] Make sure to run only one build per type per node" * mono/mono@9ec28a5cdfc [ci] Add node name to log of Jenkins pipeline builds * mono/mono@0d60209c63e [2019-02] [System.Net.Http] Move NSUrlSessionHandler from xamarin-macios to mono (#13249) * mono/mono@66a15f77b32 [2019-02] [monodroid] Use CoreFX to implement System.Drawing types that used to be in Mono.Android.dll (#13237) * mono/mono@5fc4dc076d8 [android] Fix inaccurate detection of sendfile() * mono/mono@a342f2e4af4 Bump corefx for type forwarders ported from 2018-10 Xamarin.Android integration * mono/mono@0aac8c4e0ff [2019-02] Fix multiple issues with response file option on Windows. (#13176) * mono/mono@077ca320a8c [aot] use unbox arbitrary trampolines for "slim" mscorlib (#13167) * mono/mono@f438e1b2608 [2019-02] [aot] abort lookup early when a method isn\u0027t available in AOT image (#13178) * mono/mono@60deb21fd85 [ci] Use dl.internalx.com when building on private Jenkins * mono/mono@979cf7978bf [aot] Resolve profile against compiled assembly (#13156) * mono/mono@b4f8e8a698f [System] Bump SocketTest.TestSelect1 socket timeout to 1ms (#13152) * mono/mono@ed72d79edaf Bump API snapshot submodule * mono/mono@39e7d07270d Make `System.dll` internals visible to `Mono.Android`. * mono/mono@5809340a13e [nuget] Add new versions of System.Net.Http * mono/mono@48ce16320f0 [nuget] Add new versions of System.Text.Encoding.CodePages .. * mono/mono@a3f69d7b21c [sdks] Make sure to run only one build per type per node * mono/mono@2ba053262fb use for loop to access item values and avoid InvalidCastException which occurs because VirtualDirectoryMappingCollection enumerator returns key and it's not expected * mono/mono@8f9491c094c [loader] Fix off by 1 (netstandard is a framework facade) * mono/mono@91a7262377e Bump bockbuild for GTK fix * mono/mono@076b66a58a8 Bump ikdasm * mono/mono@5212219db3f [mcs] Remove doc about CAS security * mono/mono@237e312ff74 Pass X509Certificate2 to the certificate validator. (#13036) * mono/mono@4c2b1492641 Remove leading . from script invocation (#13051) * mono/mono@1ce836d47d8 [2019-02] Bump linker submodule to latest master (#13034) * mono/mono@737f6ae708a Set executable bit for all .sh files in repo * mono/mono@0c2b8e9f24c Correct access permissions to include "user execute" for run-msbuild.sh. (#13042) * mono/mono@b9fa0ff8072 [bitcode] round up value type size for slot calculation (#13008) * mono/mono@3ba037bc239 Revert "[Facades] Remove System.Drawing.Primitives from xammac_net_4_5_SUBDIRS" * mono/mono@99dc534da08 [Facades] Remove System.Drawing.Primitives from xammac_net_4_5_SUBDIRS * mono/mono@55c62ea3992 [2019-02] [sdks] Add mac-{mac32,mac64} targets (#12977) * mono/mono@e62516b7aa4 [2019-02] [crash] Add more detailed reporting for exceptions (#13000) * mono/mono@143e2151e6e [System.Net.Http] Improve HttpClientTest to use the retry http listener (#13003) * mono/mono@5c66a3da2f5 [2019-02] [ci] Fix Linux x64 Bitcode job (#13004) * mono/mono@5c6e79ffa78 Mono.Native: Simplify checking for min-version * mono/mono@1f1942c356c [corlib] Fix CustomAttributeDataTest.MethodIncludesDllImportAttributeData() on watch/tv * mono/mono@7c3abd8e0d9 [2019-02] [debugger] Reverting part of mono/mono#12114 (#12960) * mono/mono@f7f0580b047 [2019-02] [ios] add crosswatch64_32 target (#12939) * mono/mono@4da62d45683 [2019-02] Bump cecil submodule (#12942) * mono/mono@d1bab8193bd Update roslyn-binaries submodule to point to latest master revision * mono/mono@f3bdb526f0c Fix issue where togglerefs might be incorrectly pinned. (#12815) * mono/mono@fc80faabb09 [ci] Bump bockbuild to get fontconfig download url fix * mono/mono@1790e8a88f5 [aot] interp flag on AOT images only on mscorlib required (#12891) * mono/mono@765166c97a1 [interp] Fix ldelema (#12929) * mono/mono@14c5f6cc418 [2019-02] [interp] Add method to seq_points table after we finish registering it (#12908) * mono/mono@6ad34f458f0 [arm/bitcode] mark valuetype returns as such when dealing with pinvokes (#12912) * mono/mono@7f5125179dd [ci] Support building the OSX .pkg on private Jenkins * mono/mono@062e05b4f70 Merge pull request #12860 from monojenkins/backport-pr-12856-to-2019-02 * mono/mono@9f6ad1ef7a1 FIxing crash where a generic enum is passed into get_shared_type. Also added automated test to catch this scenario. (#12848) * mono/mono@f218806bf33 [2019-02] [metadata] Fix dynamic delegate (#12812) * mono/mono@e9c6379247f [2019-02] [arm64] encode offset within stack slot for r4 in gsharedvt descriptor (#12887) * mono/mono@77b48ca726c [sre] Handle null values in MarshalAsAttribute CustomAttributeBuilder * mono/mono@1dcd3134125 [runtime] Use temp folders for merp tests (#12870) * mono/mono@6abff04d78e [2019-02] [ios] pass --enable-monotouch to cross compilers so icall defintions are visible to it (#12836) * mono/mono@3101d1c7fbd [Registry] Prevent crash due to background thread facing problems in the file system * mono/mono@35aea5b0efc [tests] Disable flaky block_guard_restore_aligment_on_exit.exe on Windows PRs * mono/mono@034f1d68a35 [2019-02] Add support for async-streams (C# 8.0). (#12832) * mono/mono@fd9b8567d5a [2019-02] [corlib] Remove reflection-based Mono.Native test (#12828) * mono/mono@ea3ee83061c [2019-02] Extend mono-native minimum version magic to CPPFLAGS/CXXFLAGS (#12813) Diff: mono/mono@6fe4c14...c8906be

rolfbjarne · 2019-03-08T18:32:23Z

build

The sn tool is used during the build to sign assemblies, but with a twist: It uses the MONO_CFG_DIR environment variable to force a custom machine.config from the 4.5/mono/machine.config directory with custom key mappings. That in turn also changes where the global dllmap file is looked up though and now that certain core parts of the BCL rely on System.Native we need to make sure we have it in place.

…ogic

Some tests require ref structs now which needs latest C#.

It was removed in Mono when moving to the corefx implementation. Replaced it with the original implementation (though we probably shouldn't rely on internals...)

The changes in mono are changing threading. This means that the code is getting deadlock in the ReadStreamData. This happens because we were not removing the handlers from the first requests events. Initially, before we had to take care about the auth headers, this was needed to init certain internal state for the HttpContent that was sexposed to the user. With the fix of the CVE, the first request, in case of a redirect, is garbage and is ignored. The second request is the one returned to the user and contains all the required info. Removing the event handlers, ensure that HandleClose is not called and therefore ReadStream is never called.

xamarin-release-manager · 2019-04-16T12:09:59Z

✅ Jenkins job (on internal Jenkins) succeeded

✅ Build succeeded
✅ Packages: xamarin.ios-12.11.0.473.pkg xamarin.mac-5.11.0.473.pkg
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
ℹ️ Test run skipped: Not running tests here because they're run on public Jenkins.

monojenkins · 2019-04-16T16:00:23Z

Build failure
❌ Build was aborted

xamarin-release-manager · 2019-04-16T17:38:42Z

✅ Jenkins job (on internal Jenkins) succeeded

✅ Build succeeded
✅ Packages: xamarin.ios-12.11.0.474.pkg xamarin.mac-5.11.0.474.pkg
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
ℹ️ Test run skipped: Not running tests here because they're run on public Jenkins.

monojenkins · 2019-04-17T00:20:09Z

Build failure
❌ Build was aborted

New commits in mono/mono: * mono/mono@158b6137fae [corefx] Use fallbacks when link() fails * mono/mono@5a9fb2376d9 [MacSDK] Bump F# to 4.5 (#10919) * mono/mono@eb478b5163c [gsharedvt] Fix sizeof opcode (#13831) * mono/mono@d67de36ffbb [2019-02] [arm] align stack pointer in throw trampoline (#14083) * mono/mono@d3ece1d29f8 [2019-02] [aot] change method table generation so that it works for larger assemblies on ARM (#14052) * mono/mono@d76895f97fc [WinForms] Fix displayed image in TreeNode when ImageIndex set to -2 When ImageIndex in TreeNode set to -2 must not displayed any image Diff: https://github.com/mono/mono/compare/d75c142a4646af45f680cd90cafe05843d1d5945..158b6137fae610d3efb8741e2375eb57959101a4

…test suite It's actually an important distinction.

We need to avoid selecting some unrelated type that could conflict between assemblies like FileCleanupTestBase.

The missing test assemblies validator wasn't matching them since it looked for monotouch_, instead of monotouch_watch_

New commits in mono/mono: * mono/mono@cf880be66a2 [Mono.Runtime.Tests] Exclude simd tests Diff: https://github.com/mono/mono/compare/158b6137fae610d3efb8741e2375eb57959101a4..cf880be66a2d1cc8ca34e345114a7f420b7b86ea

xamarin-release-manager · 2019-04-17T20:33:35Z

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Build' 🔥 : org.jenkinsci.plugins.workflow.steps.FlowInterruptedException

🔥 Build failed 🔥

monojenkins · 2019-04-18T03:15:33Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'
🔥 Test run failed 🔥

Test results

3 tests failed, 0 tests skipped, 228 tests passed.

Failed tests

[xUnit] Mono BCL tests group 6/iOS Unified 32-bits - simulator/Debug: TimedOut
[NUnit] Mono SystemXmlTests/watchOS - simulator/Debug: Crashed
[xUnit] Mono SystemDataXunit/watchOS - simulator/Debug: Crashed

xamarin-release-manager · 2019-04-25T03:01:00Z

✅ Jenkins job (on internal Jenkins) succeeded

✅ Build succeeded
✅ Packages: xamarin.ios-12.11.0.502.pkg xamarin.mac-5.11.0.502.pkg
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
ℹ️ Test run skipped: Not running tests here because they're run on public Jenkins.

monojenkins · 2019-04-25T05:16:36Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'
🔥 Test run failed 🔥

Test results

6 tests failed, 0 tests skipped, 225 tests passed.

Failed tests

[NUnit] Mono SystemNumericsTests/watchOS - simulator/Debug: Crashed
[NUnit] Mono SystemServiceModelWebTests/watchOS - simulator/Debug: Crashed
[NUnit] Mono SystemServiceModelTests/watchOS - simulator/Debug: Crashed
[xUnit] Mono SystemSecurityXunit/watchOS - simulator/Debug: Crashed
[xUnit] Mono SystemRuntimeSerializationXunit/watchOS - simulator/Debug: Crashed
MTouch tests/NUnit: Failed (Execution failed with exit code 1)

We build for both armv7 and arm64, and the failure we're looking for can happen with either architecture. The order in which the architectures are built is random, and mtouch will fail once the first error occurs, which means that we can't assert that the failure comes from the arm64 build, since the armv7 build might have been executed first (and triggered the error). So just don't assert that the expected error message contains the architecture, which makes the assert valid for both armv7 and armv64.

xamarin-release-manager · 2019-04-25T10:14:51Z

✅ Jenkins job (on internal Jenkins) succeeded

✅ Build succeeded
✅ Packages: xamarin.ios-12.11.0.503.pkg xamarin.mac-5.11.0.503.pkg
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
ℹ️ Test run skipped: Not running tests here because they're run on public Jenkins.

monojenkins · 2019-04-25T15:10:46Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'
🔥 Test run failed 🔥

Test results

1 tests failed, 0 tests skipped, 230 tests passed.

Failed tests

[xUnit] Mono SystemLinqXunit/watchOS - simulator/Debug: Crashed

dotMorten · 2019-06-26T15:34:27Z

I think this might have caused this regression:

https://developercommunity.visualstudio.com/content/problem/623875/xamarinios-fails-to-link-when-using-the-systemdraw.html

marek-safar · 2019-06-27T12:21:18Z

@akoeplinger could you confirm ^

akoeplinger · 2019-07-09T11:41:20Z

As mentioned on the DevCommunity ticket it was caused by a mismatching XI/XM between Windows and Mac.

Bump to mono:2019-02

80ee9cb

directhex requested a review from rolfbjarne as a code owner February 6, 2019 15:10

directhex added enable-device-build Makes our build include device support (which we disable for simple PRs to speed them up) run-all-tests Run all our tests. labels Feb 6, 2019

directhex assigned rolfbjarne, spouliot and akoeplinger Feb 6, 2019

This comment has been minimized.

Sign in to view

marek-safar mentioned this pull request Feb 7, 2019

2019-02 Mono Release mono/mono#12846

Closed

13 tasks

rolfbjarne added 2 commits March 8, 2019 16:32

Merge remote-tracking branch 'origin/master' into mono-2019-02

c7db380

This comment has been minimized.

Sign in to view

akoeplinger added 10 commits March 13, 2019 00:34

Merge branch 'master' into mono-2019-02

bb6feb4

Bump mono

53146a3

Move NSUrlSessionHandler to Mono

6caee47

Update mmp/mtouch projects to add new linker files and adapt to new l…

8274161

…ogic

Use LangVersion=latest in mscorlib test csproj

60812c0

Some tests require ref structs now which needs latest C#.

Move System.Drawing types to Mono

3c156f7

Don't use internal MethodBase.FullName anymore

8ad5199

It was removed in Mono when moving to the corefx implementation. Replaced it with the original implementation (though we probably shouldn't rely on internals...)

Merge remote-tracking branch 'upstream/master' into mono-2019-02

0bcbb67

Workaround GuiUnit csproj issue

fb38e76

akoeplinger added build-package Build (and create package) on internal Jenkins. Apply 'run-internal-tests' to run tests too. skip-ios-device-tests skip-api-comparison Skips API / generator diffs when testing pull requests labels Mar 13, 2019

Fix missing file in System-mac.csproj.template

8c96fb2

Workaround #5760 in generator csproj

9bd927b

akoeplinger added 9 commits April 17, 2019 11:29

Merge remote-tracking branch 'upstream/master' into mono-2019-02

0da0bca

Reenable tests that were fixed

dbbc954

bcl-test-importer: Append .Unsafe to System.Runtime.CompilerServices …

b1dc785

…test suite It's actually an important distinction.

Add System.Runtime.CompilerServices.Unsafe xunit test to iOS

65153f4

bcl-test-importer: Select first type that ends with Test/Tests

fc7008d

We need to avoid selecting some unrelated type that could conflict between assemblies like FileCleanupTestBase.

bcl-test-importer: Correctly process watch/tv assemblies

3ebafb9

The missing test assemblies validator wasn't matching them since it looked for monotouch_, instead of monotouch_watch_

bcl-test-importer: Add three more unit test assemblies

8ed5e39

Bump mono

946e017

New commits in mono/mono: * mono/mono@cf880be66a2 [Mono.Runtime.Tests] Exclude simd tests Diff: https://github.com/mono/mono/compare/158b6137fae610d3efb8741e2375eb57959101a4..cf880be66a2d1cc8ca34e345114a7f420b7b86ea

Merge remote-tracking branch 'upstream/master' into mono-2019-02

99ea097

rolfbjarne approved these changes Apr 25, 2019

View reviewed changes

spouliot approved these changes Apr 25, 2019

View reviewed changes

akoeplinger merged commit 7f717f0 into master Apr 25, 2019

mandel-macaque deleted the mono-2019-02 branch December 7, 2021 20:29

Bump to mono:2019-02 #5563

Bump to mono:2019-02 #5563

Uh oh!

Conversation

directhex commented Feb 6, 2019

Uh oh!

This comment has been minimized.

spouliot commented Feb 13, 2019

Uh oh!

rolfbjarne commented Feb 14, 2019

Uh oh!

This comment has been minimized.

rolfbjarne commented Mar 8, 2019

Uh oh!

This comment has been minimized.

xamarin-release-manager commented Apr 16, 2019

Uh oh!

monojenkins commented Apr 16, 2019

Uh oh!

xamarin-release-manager commented Apr 16, 2019

Uh oh!

monojenkins commented Apr 17, 2019

Uh oh!

xamarin-release-manager commented Apr 17, 2019

Uh oh!

monojenkins commented Apr 18, 2019

Test results

Failed tests

Uh oh!

xamarin-release-manager commented Apr 25, 2019

Uh oh!

monojenkins commented Apr 25, 2019

Test results

Failed tests

Uh oh!

xamarin-release-manager commented Apr 25, 2019

Uh oh!

monojenkins commented Apr 25, 2019

Test results

Failed tests

Uh oh!

dotMorten commented Jun 26, 2019

Uh oh!

marek-safar commented Jun 27, 2019

Uh oh!

akoeplinger commented Jul 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants