[AuthenticationServices] Add AuthenticationServices bindings for xcode11.2 #7315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
mandel-macaque
suggested changes
Oct 28, 2019
Contributor
mandel-macaque
left a comment
mandel-macaque
left a comment
There was a problem hiding this comment.
Changing the enums value, is a breaking change like: #7292
mandel-macaque
approved these changes
Oct 28, 2019
Contributor
mandel-macaque
left a comment
mandel-macaque
left a comment
There was a problem hiding this comment.
I missed that Default == Sigin, should be ok.
spouliot
suggested changes
Oct 28, 2019
Contributor
spouliot
left a comment
spouliot
left a comment
There was a problem hiding this comment.
The headers might say so but, in reality, there never was a tvOS 13.1. It went from 13.0 to 13.2
Collaborator
|
Build failure Test results1 tests failed, 90 tests passed.Failed tests
|
spouliot
approved these changes
Oct 28, 2019
prmallic
approved these changes
Oct 28, 2019
Collaborator
|
Build failure Test results5 tests failed, 86 tests passed.Failed tests
|
rolfbjarne
approved these changes
Oct 29, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add AuthenticationServices bindings for xcode11.2