[Runtime] Enable the -Wsign-conversion on monotouch-debug files. #7459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: dotnet#7405
Collaborator
|
Build failure Test results1 tests failed, 86 tests passed.Failed tests
|
Contributor
Author
dalexsoto
approved these changes
Nov 15, 2019
Member
dalexsoto
left a comment
dalexsoto
left a comment
There was a problem hiding this comment.
Did not know about ssize_t 👍
rolfbjarne
requested changes
Nov 15, 2019
spouliot
approved these changes
Nov 16, 2019
Collaborator
|
Build failure |
Collaborator
|
Build failure Test results2 tests failed, 85 tests passed.Failed tests
|
rolfbjarne
requested changes
Nov 19, 2019
Co-Authored-By: Rolf Bjarne Kvinge <rolf@xamarin.com>
rolfbjarne
approved these changes
Nov 19, 2019
Contributor
Author
|
Known issues: https://github.com/xamarin/maccore/issues/581 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the flag that was disabled via pragmas and fix warnings.
Continuation of PR: #7405