[Runtime] Enable the -Wsign-conversion warnings flag and fix some of the warnings. #7405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he warnings. The flag adds a lot (A LOT) of warnings. The diff would be huge and dangerous to review. We enable the flag and fix file by file.
mandel-macaque
changed the title
dalexsoto
approved these changes
Nov 11, 2019
Collaborator
|
Build failure |
whitneyschmidt
approved these changes
Nov 11, 2019
Collaborator
|
Build failure |
Collaborator
|
Build failure Test results6 tests failed, 82 tests passed.Failed tests
|
rolfbjarne
requested changes
Nov 12, 2019
runtime/mono-runtime.h.t4
Outdated
|
|
||
| #ifndef GPOINTER_TO_INT | ||
| #define GPOINTER_TO_INT(p) ((int) (long) (p)) | ||
| #define GPOINTER_TO_INT(p) ((uint32_t) (long) (p)) |
Member
There was a problem hiding this comment.
This makes the macro name incorrect, so:
Suggested change
| #define GPOINTER_TO_INT(p) ((uint32_t) (long) (p)) | |
| #define GPOINTER_TO_UINT(p) ((uint32_t) (long) (p)) |
Contributor
There was a problem hiding this comment.
make sense, but the above #ifndef needs to be updated too
i.e. don't commit suggestion alone :)
Contributor
Author
There was a problem hiding this comment.
I can't it would not compile. It is a larger change (is used in several places) but can be done in this PR.
spouliot
approved these changes
Nov 12, 2019
…acaque/xamarin-macios into partial-enable-Wsign-conversion
rolfbjarne
approved these changes
Nov 12, 2019
Collaborator
|
Build failure Test results20 tests failed, 68 tests passed.Failed tests
|
Contributor
Author
|
HE0038 (https://github.com/xamarin/maccore/issues/581) and issues with the msdn page that are fixed by #7401 |
mandel-macaque
added a commit
to mandel-macaque/xamarin-macios
that referenced
this pull request
Nov 13, 2019
Enable the flag that was disabled via pragmas. Continuation of PR: dotnet#7405
mandel-macaque
added a commit
to mandel-macaque/xamarin-macios
that referenced
this pull request
Nov 13, 2019
Enable the flag that was disabled via pragmas. Continuation of PR: dotnet#7405
mandel-macaque
added a commit
that referenced
this pull request
Nov 14, 2019
Enable the flag that was disabled via pragmas. Continuation of PR: #7405
mandel-macaque
added a commit
to mandel-macaque/xamarin-macios
that referenced
this pull request
Nov 14, 2019
Enable the flag that was disabled via pragmas. Continuation of PR: dotnet#7405
mandel-macaque
added a commit
to mandel-macaque/xamarin-macios
that referenced
this pull request
Nov 14, 2019
Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: dotnet#7405
mandel-macaque
added a commit
to mandel-macaque/xamarin-macios
that referenced
this pull request
Nov 14, 2019
Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: dotnet#7405
mandel-macaque
added a commit
to mandel-macaque/xamarin-macios
that referenced
this pull request
Nov 14, 2019
Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: dotnet#7405
mandel-macaque
added a commit
to mandel-macaque/xamarin-macios
that referenced
this pull request
Nov 14, 2019
Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: dotnet#7405
mandel-macaque
added a commit
that referenced
this pull request
Nov 15, 2019
Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: #7405
mandel-macaque
added a commit
to mandel-macaque/xamarin-macios
that referenced
this pull request
Nov 15, 2019
Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: dotnet#7405
mandel-macaque
added a commit
to mandel-macaque/xamarin-macios
that referenced
this pull request
Nov 15, 2019
Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: dotnet#7405
mandel-macaque
added a commit
to mandel-macaque/xamarin-macios
that referenced
this pull request
Nov 15, 2019
Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: dotnet#7405
mandel-macaque
added a commit
to mandel-macaque/xamarin-macios
that referenced
this pull request
Nov 15, 2019
Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: dotnet#7405
mandel-macaque
added a commit
that referenced
this pull request
Nov 18, 2019
) Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: #7405
mandel-macaque
added a commit
that referenced
this pull request
Nov 20, 2019
Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: #7405
mandel-macaque
added a commit
to mandel-macaque/xamarin-macios
that referenced
this pull request
Nov 20, 2019
Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: dotnet#7405
mandel-macaque
added a commit
that referenced
this pull request
Nov 21, 2019
Enable the flag that was disabled via pragmas and fix warnings. Continuation of PR: #7405
mandel-macaque
added a commit
to mandel-macaque/xamarin-macios
that referenced
this pull request
Nov 21, 2019
Update flags: * Add -Werror so that warnings are errors. * Move to -Wconversion that adds: * -Wbitfield-enum-conversion * -Wbool-conversion * -Wconstant-conversion * -Wenum-conversion * -Wfloat-conversion * -Wimplicit-float-conversion * -Wimplicit-int-conversion * -Wint-conversion * -Wliteral-conversion * -Wnon-literal-null-conversion * -Wnull-conversion * -Wobjc-literal-conversion * -Wshorten-64-to-32 * -Wsign-conversion * -Wstring-conversion Last work related to: dotnet#7405
mandel-macaque
added a commit
that referenced
this pull request
Nov 25, 2019
Update flags: * Add -Werror so that warnings are errors. * Move to -Wconversion that adds: * -Wbitfield-enum-conversion * -Wbool-conversion * -Wconstant-conversion * -Wenum-conversion * -Wfloat-conversion * -Wimplicit-float-conversion * -Wimplicit-int-conversion * -Wint-conversion * -Wliteral-conversion * -Wnon-literal-null-conversion * -Wnull-conversion * -Wobjc-literal-conversion * -Wshorten-64-to-32 * -Wsign-conversion * -Wstring-conversion Last work related to: #7405
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag adds a lot (A LOT) of warnings. The diff would be huge and
dangerous to review. We enable the flag and fix file by file.