[Runtime] Update cflags and fix warnings accordingly. #7478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update flags: * Add -Werror so that warnings are errors. * Move to -Wconversion that adds: * -Wbitfield-enum-conversion * -Wbool-conversion * -Wconstant-conversion * -Wenum-conversion * -Wfloat-conversion * -Wimplicit-float-conversion * -Wimplicit-int-conversion * -Wint-conversion * -Wliteral-conversion * -Wnon-literal-null-conversion * -Wnull-conversion * -Wobjc-literal-conversion * -Wshorten-64-to-32 * -Wsign-conversion * -Wstring-conversion Last work related to: dotnet#7405
spouliot
approved these changes
Nov 21, 2019
rolfbjarne
approved these changes
Nov 21, 2019
Collaborator
|
Build failure Test results32 tests failed, 58 tests passed.Failed tests
|
Contributor
Author
|
build |
Collaborator
|
Build failure Test results32 tests failed, 58 tests passed.Failed tests
|
Contributor
|
That's bot 38 (first time) and 37 (2nd time) failing 32bits tests |
ghost
reviewed
Nov 25, 2019
mandel-macaque
commented
Nov 25, 2019
mandel-macaque
commented
Nov 25, 2019
ghost
approved these changes
Nov 25, 2019
Collaborator
|
Build failure Test results1 tests failed, 89 tests passed.Failed tests
|
prmallic
approved these changes
Nov 25, 2019
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update flags:
Last work related to: [Runtime] Enable the -Wsign-conversion warnings flag and fix some of the warnings. #7405