Revert Emit eval props if requested by any sink (#10243)

[JanKrivanek]

Fixes https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_git/VS/pullRequest/567354#1721971513

Context

#10243 introduced proper populating of eval props based on Loggers requests - this however can lead to props being populated on both - ProjectStartedEventArgs and EvaluationProjectFinishedEventArgs - which leads to higher allocations. We have couple options how to proceed:

• Accept the allocations increase (and close this PR)
• Revert the previous changes - however this will lead to 'enlightened' loggers missing data (if old logger ius present) - including BuildCheck going forward
• Adjust changes by populating only on EvaluationProjectFinishedEventArgs if any loggers requested - leading to breaking not enlightened loggers
• Go through all the Logger registrations and initializtions in VS and make sure they are 'enlightened' (<--- trying this right now)

[JanKrivanek]

Exp insertion: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/567559

[f-alizada]

Let's revert the change and investigate later per:
https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/2173921