Revert "Revert Emit eval props if requested by any sink (#10243)"#10508
Merged
JanKrivanek merged 3 commits intomainfrom Aug 15, 2024
Merged
Revert "Revert Emit eval props if requested by any sink (#10243)"#10508JanKrivanek merged 3 commits intomainfrom
JanKrivanek merged 3 commits intomainfrom
Conversation
JanKrivanek
commented
Aug 14, 2024
YuliiaKovalova
approved these changes
Aug 15, 2024
MichalPavlik
approved these changes
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #10447
Reintroduces changes from #10243
Fixes #10225
Context
#10243 introduced fix that ensured props/items attached to
ProjectEvaluationFinishedEventargsif requested by any logger.This however caused perf regression (https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/2173921) - as previously props/items were attached only when requested by ALL loggers. Such behavior would however break loggers requiring the props for correct functionality (e.g. BuildCheck logger).
VS insertions