Change BinLog (/bl) to no longer enable Detail Summary (/ds).#12040
Merged
YuliiaKovalova merged 1 commit intodotnet:mainfrom Jun 20, 2025
Merged
Change BinLog (/bl) to no longer enable Detail Summary (/ds).#12040YuliiaKovalova merged 1 commit intodotnet:mainfrom
YuliiaKovalova merged 1 commit intodotnet:mainfrom
Conversation
YuliiaKovalova
approved these changes
Jun 19, 2025
Member
|
cc: @KirillOsenkov |
Member
|
And yes, as a data point, I've never had the need to look at the detailed summary (or perhaps I've never learned how to read it) |
rainersigwald
approved these changes
Jun 19, 2025
Member
rainersigwald
left a comment
There was a problem hiding this comment.
I have used it but not in a long time--I think it's well superseded by other binlog/viewer features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11244
Context
When using Binary Logger (
/bl), it also enables Detail Summary (/ds). It adds 3-5% additional size to the binlog itself.BL requires diagnostic verbosity that indirectly enables DS.
Changes Made
This change will specifically not enable DS from BL by evaluating the verbosity state before upping the verbosity level. Users can still enable add
/dsor/v:diag.Testing
There isn't a unit test for this area, so manually test it.
Is Detail Summary Shown
/bl/bl /ds/bl /v:d/bl /v:diag/fl/fl /ds/fl /v:d/fl /v:diag/bl /flNotes