Skip to content

Change BinLog (/bl) to no longer enable Detail Summary (/ds).#12040

Merged
YuliiaKovalova merged 1 commit intodotnet:mainfrom
yuehuang010:dev/yuehuang/main_ds_false
Jun 20, 2025
Merged

Change BinLog (/bl) to no longer enable Detail Summary (/ds).#12040
YuliiaKovalova merged 1 commit intodotnet:mainfrom
yuehuang010:dev/yuehuang/main_ds_false

Conversation

@yuehuang010
Copy link
Copy Markdown
Contributor

Fixes #11244

Context

When using Binary Logger (/bl), it also enables Detail Summary (/ds). It adds 3-5% additional size to the binlog itself.
BL requires diagnostic verbosity that indirectly enables DS.

Changes Made

This change will specifically not enable DS from BL by evaluating the verbosity state before upping the verbosity level. Users can still enable add /ds or /v:diag.

Testing

There isn't a unit test for this area, so manually test it.

Is Detail Summary Shown

Arguments Before After
no no
/bl yes no
/bl /ds yes yes
/bl /v:d yes no
/bl /v:diag yes yes
/fl no no
/fl /ds yes yes
/fl /v:d no no
/fl /v:diag yes yes
/bl /fl yes no

Notes

@YuliiaKovalova
Copy link
Copy Markdown
Member

cc: @KirillOsenkov

@KirillOsenkov
Copy link
Copy Markdown
Member

@KirillOsenkov
Copy link
Copy Markdown
Member

And yes, as a data point, I've never had the need to look at the detailed summary (or perhaps I've never learned how to read it)

Copy link
Copy Markdown
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have used it but not in a long time--I think it's well superseded by other binlog/viewer features.

@YuliiaKovalova YuliiaKovalova merged commit 69851c0 into dotnet:main Jun 20, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove "Detail Summary" from binary logger

4 participants