Allow turning detailed summary off#6338
Merged
benvillalobos merged 2 commits intomainfrom Apr 20, 2021
Merged
Conversation
Change the DetailedSummary command-line switch from parameterless to parameterized, allowing the user to have control and explicitly set it to false if needed, overriding the default of true when the verbosity is diagnostic. This is backwards compatible with the previous behavior, so if /ds is specified, it is equivalent to turning it on. Fixes #4409
Contributor
|
Is it worth adding some code to automatically turn the detailed summary off if:
|
cdmihai
approved these changes
Apr 15, 2021
Member
Author
|
@cdmihai perhaps; but probably should be done in a separate PR. This PR just makes the detailedSummary switch parameterized, which is good to have regardless. I think it can be useful in general. |
rainersigwald
approved these changes
Apr 19, 2021
Forgind
added
the
merge-when-branch-open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the DetailedSummary command-line switch from parameterless to parameterized, allowing the user to have control and explicitly set it to false if needed, overriding the default of true when the verbosity is diagnostic.
This is backwards compatible with the previous behavior, so if /ds is specified, it is equivalent to turning it on.
Fixes #4409