Add information about binlog to stdout#12638
Conversation
| LogMessage("BinLogFilePath=" + FilePath); | ||
| LogMessage("CurrentUICulture=" + System.Globalization.CultureInfo.CurrentUICulture.Name); | ||
| Console.WriteLine("BinLogFilePath=" + FilePath); | ||
| Console.WriteLine("CurrentUICulture=" + System.Globalization.CultureInfo.CurrentUICulture.Name); |
There was a problem hiding this comment.
Do people need the culture?
As for the binlog, should this be a human readable string? perhaps "Written {0}" or something
There was a problem hiding this comment.
Not sure the culture is needed, I wanted to replicate the message, but I definitely want to make the text localizable and respect the verbosity. This was just a first draft.
|
This pull request has been automatically closed because it has been open for more than 180 days with no recent activity. If you believe this work is still relevant, please feel free to reopen or create a new pull request. Thank you for your contribution! Note 🔒 Integrity filter blocked 39 itemsThe following items were blocked because they don't meet the GitHub integrity level.
To allow these resources, lower tools:
github:
min-integrity: approved # merged | approved | unapproved | none
|
Fixes #
Context
Binlog file is produced if the option
/bl:file.binlogis used when calling MSBuild.Changes Made
Console.writeline(...)addod to the BinarryLogger.cs` to output location and name of the produced binlog file.Testing
Tested manually locally
Notes
Not sure if Console.Writeline is the right approach to print the information, plus the message should be localized. This is draft for now.