Skip to content

Add information about binlog to stdout#12638

Closed
michalbrabec wants to merge 2 commits intomainfrom
12261-consider-adding-a-message-indicating-binlog-creation
Closed

Add information about binlog to stdout#12638
michalbrabec wants to merge 2 commits intomainfrom
12261-consider-adding-a-message-indicating-binlog-creation

Conversation

@michalbrabec
Copy link
Copy Markdown

Fixes #

Context

Binlog file is produced if the option /bl:file.binlog is used when calling MSBuild.

Changes Made

Console.writeline(...) addod to the BinarryLogger.cs` to output location and name of the produced binlog file.

Testing

Tested manually locally

Notes

Not sure if Console.Writeline is the right approach to print the information, plus the message should be localized. This is draft for now.

@michalbrabec michalbrabec linked an issue Oct 14, 2025 that may be closed by this pull request
LogMessage("BinLogFilePath=" + FilePath);
LogMessage("CurrentUICulture=" + System.Globalization.CultureInfo.CurrentUICulture.Name);
Console.WriteLine("BinLogFilePath=" + FilePath);
Console.WriteLine("CurrentUICulture=" + System.Globalization.CultureInfo.CurrentUICulture.Name);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do people need the culture?

As for the binlog, should this be a human readable string? perhaps "Written {0}" or something

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure the culture is needed, I wanted to replicate the message, but I definitely want to make the text localizable and respect the verbosity. This was just a first draft.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically closed because it has been open for more than 180 days with no recent activity.

If you believe this work is still relevant, please feel free to reopen or create a new pull request. Thank you for your contribution!

Note

🔒 Integrity filter blocked 39 items

The following items were blocked because they don't meet the GitHub integrity level.

  • #13528 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13527 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13523 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13516 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13511 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13495 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13488 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13486 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13480 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13477 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13474 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13458 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13457 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13442 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13429 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #13428 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • ... and 23 more items

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
  github:
    min-integrity: approved  # merged | approved | unapproved | none

Generated by Close Stale Pull Requests · ● 844.8K

@github-actions github-actions Bot closed this Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider adding a message indicating binlog creation.

2 participants