Use source-build-assets repo#13528
Use source-build-assets repo#13528NikolaMilosavljevic wants to merge 6 commits intodotnet:vs17.12from
Conversation
NikolaMilosavljevic
requested review from
a team,
ellahathaway,
marcpopMSFT and
mthalman
There was a problem hiding this comment.
Pull request overview
Updates the source-build intermediate dependency metadata to reflect the source-build-reference-packages repo rename to source-build-assets, enabling VMR/source-build scenarios to resolve the correct repository/package.
Changes:
- Switched the intermediate dependency from
source-build-reference-packagestosource-build-assets. - Updated the dependency version, repo URI, and SHA to the new package source.
|
/review |
|
✅ Expert Code Review (command) completed successfully! Expert-reviewer subagent completed and posted its review for PR #13528. Finding: the PR removes the trailing newline from eng/Version.Details.xml (violating editorconfig insert_final_newline=true); the dependency rename from source-build-reference-packages to source-build-assets and version bump 17.12.58→17.12.59 are otherwise clean with no stale references remaining. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
Changes reviewed:
- Dependency rename:
source-build-reference-packages→source-build-assets(Name, Uri, Sha, RepoName all updated consistently) - Version bump:
17.12.58→17.12.59
Findings:
- ✅ No stale references to
source-build-reference-packagesremain anywhere in the repository — the rename is complete. - ✅ The version bump in
Versions.propsis a routine patch increment. ⚠️ Minor: The trailing newline was removed fromeng/Version.Details.xml, which conflicts with the repo's.editorconfigrule (insert_final_newline = truefor[*]). See inline comment.
Note
🔒 Integrity filter blocked 1 item
The following item were blocked because they don't meet the GitHub integrity level.
- #13528
pull_request_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
To allow these resources, lower min-integrity in your GitHub frontmatter:
tools:
github:
min-integrity: approved # merged | approved | unapproved | noneGenerated by Expert Code Review (command) for issue #13528 · ● 1.2M
|
Moving to draft - this change is likely not needed for source-build anymore. Will close this PR in a couple days unless something changes with requirements. |
source-build-reference-packagesrepo was renamed tosource-build-assets. To enable VMR/source-build scenarios this reference needs to be updated. This also updates the version as the new repo produced a new package.