Do not check first byte before handshake#5415
Closed
Forgind wants to merge 5 commits into
Closed
Conversation
rainersigwald
approved these changes
Jun 9, 2020
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
rainersigwald
added
the
merge-when-branch-open
danmoseley
reviewed
Jun 15, 2020
| /// If specified, leading byte matches one in the supplied array if any, returns rejection byte and throws IOException. | ||
| /// </summary> | ||
| internal static long ReadLongForHandshake(this PipeStream stream, byte[] leadingBytesToReject, | ||
| internal static long ReadLongForHandshake(this PipeStream stream, |
Member
There was a problem hiding this comment.
Since this handshake has caused some pain, maybe consider in the exceptions (like the one below) including the hex form of the bytes that were received (and possibly what was expected, if it was different)
Member
|
Is this still a good idea or should we just skip it in favor of the "just send components" approach we discussed in #5439? |
Contributor
Author
|
I'd vote for taking this now until I've finished that change. The handshake is calculated pretty early, so it's taking some time to string through the new struct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to dotnet/runtime#37333. This is an alternate (and, perhaps, better) way to resolve the problem.