Updating setting SDK resolver isRunningInVisualStudio#5562
Conversation
|
@Forgind @benvillalobos this change was suggested by Rainer on teams |
benvillalobos
left a comment
benvillalobos
left a comment
There was a problem hiding this comment.
You tested it and this uses code that's already being used immediately after. LGTM!
Forgind
left a comment
Forgind
left a comment
There was a problem hiding this comment.
Is there any reason to keep the RunningInVisualStudio version? If not, may as well remove it.
|
@Forgind this seems low risk and unblocks Sarah. Let's prioritize it in the PR meeting tomorrow. |
@Forgind I'm not sure what you mean, can you clarify? This change doesn't remove anything, it just changes the way this context property is set. |
|
I was thinking of #5501. You wanted that so you could do the thing you just replaced, right? Was there more? |
|
#5501 set the groundwork for this change as well as added an overload for the SDK resolver IndicateSuccess method, so none of that can be removed. |
3 participants
Tested manually along with dotnet/sdk#12633