Skip to content

Updating setting SDK resolver isRunningInVisualStudio #5562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Forgind merged 1 commit into from
Jul 31, 2020
Merged

Updating setting SDK resolver isRunningInVisualStudio #5562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Build/Evaluation/Evaluator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ private Evaluator(
_sdkResolverService = sdkResolverService;
_submissionId = submissionId;
_evaluationProfiler = new EvaluationProfiler(profileEvaluation);
_isRunningInVisualStudio = BuildEnvironmentHelper.Instance.RunningInVisualStudio;
_isRunningInVisualStudio = String.Equals("true", _data.GlobalPropertiesDictionary.GetProperty("BuildingInsideVisualStudio")?.EvaluatedValue, StringComparison.OrdinalIgnoreCase);

// In 15.9 we added support for the global property "NuGetInteractive" to allow SDK resolvers to be interactive.
// In 16.0 we added the /interactive command-line argument so the line below keeps back-compat
Expand Down