Conversation
|
Asset manifest sample
|
benvillalobos
left a comment
benvillalobos
left a comment
There was a problem hiding this comment.
Mostly LGTM. So the permanent change here really just setting PublishingVersion to 3 in Publishing.props, and all other changes are temp workarounds to get that to work right?
| - ${{ if and(eq(parameters.runAsPublic, 'false'), ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}: | ||
| - task: NuGetAuthenticate@0 | ||
|
|
||
| - task: PowerShell@2 |
There was a problem hiding this comment.
My understanding has typically been that anything under eng/common is "stuff arcade owns". Will this be overridden if arcade bumps up a version?
Presumably the fix would be in far before we even do that, but I'm curious.
There was a problem hiding this comment.
This fix will block arcade update till I get the other fix out. I am going to be working on it next week. I will have to coordinate with the arcade-services roll out. I will keep you posted on that.
| targetType: 'inline' | ||
| script: | | ||
| Write-Host "Overwriting BUILD_REPOSITORY_URI." | ||
| Write-Host "##vso[task.setvariable variable=BUILD_REPOSITORY_URI;]https://dnceng@dev.azure.com/dnceng/internal/_git/dotnet-msbuild" |
There was a problem hiding this comment.
Was BUILD_REPOSITORY_URI being used before?
There was a problem hiding this comment.
It is used when generating the asset manifest and during publishing build assets...
benvillalobos
left a comment
benvillalobos
left a comment
There was a problem hiding this comment.
LGTM. We're going to have to stop taking arcade updates until the temporary solution gets a permanent fix. We shouldn't have a problem with that, considering we've been on 1.0 until now.
One thing that could potentially break us is the signing issue we've had in the past that required us to take an arcade update.
3 participants
Fixes #
Context
Onboarding to V3 publishing.
Link to what is V3 -> https://github.com/dotnet/arcade/blob/master/Documentation/CorePackages/Publishing.md#what-is-v3-publishing-how-is-it-different-from-v2
Changes Made
Testing
CI build - https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=4391278&view=results
Promotion pipeline - https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=4391300&view=results
Notes
Hardcoding of BUILD_REPOSITORY_URI is temporary fix. This will be reverted once this is fixed dotnet/arcade#6827