Skip to content

Revert "Onboarding to V3 publishing "#6073

Merged
epananth merged 1 commit intomasterfrom
revert-6052-v3-publish
Jan 23, 2021
Merged

Revert "Onboarding to V3 publishing "#6073
epananth merged 1 commit intomasterfrom
revert-6052-v3-publish

Conversation

@epananth
Copy link
Copy Markdown
Member

Reverts #6052

Going to revert this change, as the change is making the build flaky.

@epananth epananth self-assigned this Jan 22, 2021
@benvillalobos
Copy link
Copy Markdown
Member

So our pipeline builds should work (🤞) when this and dotnet/arcade#6840 are merged in? Any other changes required?

@epananth
Copy link
Copy Markdown
Member Author

epananth commented Jan 22, 2021

I am going to make the change in ms-build, so you don't have to wait for arcade update.. You will be unblocked as soon as the other PR merges..

@benvillalobos
Copy link
Copy Markdown
Member

Gotcha, clarifying for others here:

The linked arcade PR was merged, normally we'd have to wait for an automated "arcade update" PR to take the changes. Instead, we're going to merge this PR then create that automated PR ourselves to get us unblocked.

Eventually we'll get the automated arcade update and we'll merge that in to be back in sync.

@benvillalobos
Copy link
Copy Markdown
Member

This is blocked on getting a successful optprof run for MSBuild, which is blocked on applying a new azure subscription for our optprof collection release. Our previous subscription was invalidated just in time for this 😮

@epananth
Copy link
Copy Markdown
Member Author

what do you suggest? so I cannot merge this, and the build won't be successful till I get my post-build fix

@benvillalobos
Copy link
Copy Markdown
Member

@epananth For now I'd suggest prepping the next PR so that when we do get a solid optprof run we can merge the two quickly. Until then, I guess MSBuild just has to wait until that subscription gets renewed. I've tried about 7 different ways to trick our builds into using some other optprof data to no avail ¯_(ツ)_/¯

@epananth
Copy link
Copy Markdown
Member Author

If we have to wait, msbuild will get an arcade update on Monday anyway.

@epananth epananth merged commit a6a669e into master Jan 23, 2021
@Forgind Forgind deleted the revert-6052-v3-publish branch December 6, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants