Handle unsupported paths in ProjectInSolution.AbsolutePath#6272
Closed
benvillalobos wants to merge 3 commits intodotnet:vs16.9from
Closed
Handle unsupported paths in ProjectInSolution.AbsolutePath#6272benvillalobos wants to merge 3 commits intodotnet:vs16.9from
benvillalobos wants to merge 3 commits intodotnet:vs16.9from
Conversation
dotnet#5950 introduced a call to `Path.GetFullPath()` to get a path that is normalized. However, in some cases Visual Studio stores unsupported paths which will cause `Path.GetFullPath()` to throw. `Path.GetFullPath()` can also throw a `PathTooLongException` which is now handled. Fixes dotnet#6236
…ng to normalize the path
Contributor
|
Its been a while since I did servicing, but I was wondering if it would be better to cherry-pick the actual commit that went into main? I think that would make it easier to tell what commits are in main and what commits are in this branch? The commits you cherry-picked are from my branch and not the squashed commit that went in. But again, I might not fully know what the best option is either. Here's a draft PR of the cherry-pick from main to vs16.9: #6273 |
Member
Author
|
@jeffkl I think you're right. The process should have been to merge into vs16.9, then vs16.9 would flow into master, merging the squashed commit. Let's go with your PR (thanks for making that btw). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Recreating #6238 to merge into 16.9.
Notes
Created by branching off of upstream/vs16.9 and cherry-picking each commit.
Sign off for 16.9.3 is 4/12
/cc: @jeffkl @donovan-ecargo