branding update#6321
Conversation
|
No, please don't change v160 to v170 now - v170 does not exist yet (but will in Preview 2 and more msbuild.exe.config changes will be needed then) |
| <assemblyIdentity name="Microsoft.Build.CPPTasks.Common" culture="neutral" publicKeyToken="b03f5f7f11d50a3a" /> | ||
| <bindingRedirect oldVersion="16.0.0.0-16.10.0.0" newVersion="16.10.0.0" /> | ||
| <codeBase version="16.10.0.0" href="..\..\..\Microsoft\VC\v160\Microsoft.Build.CPPTasks.Common.dll" /> | ||
| <bindingRedirect oldVersion="16.0.0.0-17.0.0.0" newVersion="17.0.0.0" /> |
There was a problem hiding this comment.
Can app.config files read properties from the build? Or is it possible to define some variable that will update each app.config? (not a blocking question)
There was a problem hiding this comment.
You still need codebase, I believe
<codeBase version="17.0.0.0" href="..\..\..\Microsoft\VC\v160\Microsoft.Build.CPPTasks.Common.dll" />
There was a problem hiding this comment.
On the other hand, how about just removing this redirect? It won't be needed for 17.0
There was a problem hiding this comment.
Yes, please remove Microsoft.Build.CPPTasks.Common from msbuild.exe.config at all. We don't want a redirect between major versions (and I plan to investigate if we can get rid of the redirect between minor versions as well)
There was a problem hiding this comment.
Should we leave it but make it not do anything (that is, oldVersion="17.0.0.0-17.0.0.0") rather than removing it entirely? I'm thinking of when we start updating it, at which point it would be nicer to have the version already there and be able to just modify it.
There was a problem hiding this comment.
No, please remove. My hope is that we won't need to add it again
There was a problem hiding this comment.
if you are removing it, you need to remove the whole segment
<dependentAssembly>
<assemblyIdentity name="Microsoft.Build.CPPTasks.Common" culture="neutral" publicKeyToken="b03f5f7f11d50a3a" />
<bindingRedirect oldVersion="16.0.0.0-17.0.0.0" newVersion="17.0.0.0" />
<codeBase version="17.0.0.0" href="..\..\Microsoft\VC\v160\Microsoft.Build.CPPTasks.Common.dll" />
</dependentAssembly>
branding update
* branding update (#6321) branding update * Additional 17.0 branding/internal updates * Update src/Utilities/ToolLocationHelper.cs Co-authored-by: Rainer Sigwald <raines@microsoft.com> * Update vsix Co-authored-by: Rainer Sigwald <raines@microsoft.com> Co-authored-by: Ben Villalobos <4691428+BenVillalobos@users.noreply.github.com>
Branding update for 17.0.
I skipped the readme changes, since I what we normally put would not be true at this point, since we haven't forked for 16.11 or even 16.10, and changes in main (we expect) will go into 16.10/11 still.
@olgaark, should I change
..\..\..\Microsoft\VC\v160\Microsoft.Build.CPPTasks.Common.dllto..\..\..\Microsoft\VC\v170\Microsoft.Build.CPPTasks.Common.dll?Are there any other changes that need to be made for a major version release?