Merged
Conversation
Contributor
|
@ooooolivia Can you confirm if this impacts the SDK team's matrix? As 2.2 is out of support we should probably make sure they know we're going to turn it off. Please hold off merging this until we get that confirmation, @adamsitnik. It LGTM but I want to make sure we aren't impacting something else. |
Contributor
Currently SDK tests do not have 2.2 in the matrix so it should be fine. |
Member
Author
|
Thank you for the reviews! #merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've removed everything related to 2.2 which is not supported since 23rd of December 2019
As requested by @billwert I've also created 2.2 branch: https://github.com/dotnet/performance/tree/2.2
I've also noticed that 3.1 was not on the list, so I've added it. I've also updated the docs to show 3.1 vs 5.0 as the example comparison since this is what we care about the most for the next release.
fixes #1000