[MAUI] Enable iOS ipa file size measurement #2295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ir name included.
DrewScoggins
reviewed
Mar 9, 2022
src/scenarios/helloios/pre.py
Outdated
| exit(-1) | ||
|
|
||
| appFolderPath = os.path.join(baseDir, appFolder[0]) | ||
| for subfile in os.listdir(appFolderPath): |
Member
There was a problem hiding this comment.
Why are we moving the extracted files after unzipping rather than just measuring the size where we unpack them?
Member
Author
There was a problem hiding this comment.
The main reason was because the structure of the unzipped ipa is folder.app/{interesting files}. I can play around with it a little bit more to and see if I can get the dirs argument to set the directory to parse to work instead though.
Member
Author
There was a problem hiding this comment.
I double checked some assumptions I made about the ipa file structure and they were incorrect so I removed the moving section to match measuring the whole zip file.
… levels in IPA files.
Member
Author
|
The failing sections are failing in main, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for measuring ipa files to the Maui and iOS pre.py files. This also includes the addition of passing in the name of the folder/file you want to use in testing. This is a sibling commit to dotnet/runtime#66358.