Skip to content

Conversation

@LoopedBard3
Copy link
Member

Adds IPA file usage for iOS Maui SOD. This included adding necessary profile signing and provisioning in the building steps, piping the changes through the pipeline, and making changes in the Perf repository to support them.

@LoopedBard3 LoopedBard3 requested a review from DrewScoggins March 8, 2022 21:20
@LoopedBard3 LoopedBard3 self-assigned this Mar 8, 2022
@ghost
Copy link

ghost commented Mar 8, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Adds IPA file usage for iOS Maui SOD. This included adding necessary profile signing and provisioning in the building steps, piping the changes through the pipeline, and making changes in the Perf repository to support them.

Author: LoopedBard3
Assignees: LoopedBard3
Labels:

area-Infrastructure-coreclr

Milestone: -

@LoopedBard3 LoopedBard3 requested a review from akoeplinger March 8, 2022 21:21
@LoopedBard3
Copy link
Member Author

The sibling commit for this on the performance repository is dotnet/performance#2295

@LoopedBard3 LoopedBard3 requested a review from SamMonoRT March 9, 2022 17:42
@SamMonoRT SamMonoRT requested a review from rolfbjarne March 9, 2022 17:45
@@ -0,0 +1,106 @@
#!/usr/bin/env bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this copied from another location? If so can we put a comment so that we know where this comes from if we need to update this file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akoeplinger is this something we would have to worry about needing updates from someplace else?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, this is a script I wrote myself.

<HelixWorkItem Include="SOD - iOS HelloWorld .app Size">
<PayloadDirectory>$(WorkItemDirectory)</PayloadDirectory>
<PreCommands>cd $(ScenarioDirectory)helloios;xcopy %HELIX_CORRELATION_PAYLOAD%\iosHelloWorld\$(LlvmPath) .\app\/e;$(Python) pre.py</PreCommands>
<PreCommands>cd $(ScenarioDirectory)helloios;xcopy %HELIX_CORRELATION_PAYLOAD%\iosHelloWorld\$(LlvmPath) .\app/e/i;$(Python) pre.py --name app</PreCommands>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I understand the --name app part. Is there a file that is created that is just called app?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, app is the folder that the llvm is copied into in the xcopy step. Ultimately, the addition of the name app part is to support the new pre.py that doesn't assume app is the folder everything is copied into.

Copy link
Member

@DrewScoggins DrewScoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would like to hear back from @akoeplinger about the provisioning script

@LoopedBard3 LoopedBard3 merged commit f06d2c0 into dotnet:main Mar 9, 2022
@LoopedBard3 LoopedBard3 deleted the MakeiOSSODUseIPA branch March 9, 2022 22:55
@ghost ghost locked as resolved and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants