-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[MAUI][PERF] Add IPA file usage for iOS Maui SOD #66358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Switches from simulator builds to device builds so we can track the size for the .ipa. We generate a dummy codesigning cert and provisioning profile since device builds require that.
… app have it's subfolders copied.
|
Tagging subscribers to this area: @hoyosjs Issue DetailsAdds IPA file usage for iOS Maui SOD. This included adding necessary profile signing and provisioning in the building steps, piping the changes through the pipeline, and making changes in the Perf repository to support them.
|
|
The sibling commit for this on the performance repository is dotnet/performance#2295 |
| @@ -0,0 +1,106 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this copied from another location? If so can we put a comment so that we know where this comes from if we need to update this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akoeplinger is this something we would have to worry about needing updates from someplace else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, this is a script I wrote myself.
| <HelixWorkItem Include="SOD - iOS HelloWorld .app Size"> | ||
| <PayloadDirectory>$(WorkItemDirectory)</PayloadDirectory> | ||
| <PreCommands>cd $(ScenarioDirectory)helloios;xcopy %HELIX_CORRELATION_PAYLOAD%\iosHelloWorld\$(LlvmPath) .\app\/e;$(Python) pre.py</PreCommands> | ||
| <PreCommands>cd $(ScenarioDirectory)helloios;xcopy %HELIX_CORRELATION_PAYLOAD%\iosHelloWorld\$(LlvmPath) .\app/e/i;$(Python) pre.py --name app</PreCommands> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure I understand the --name app part. Is there a file that is created that is just called app?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, app is the folder that the llvm is copied into in the xcopy step. Ultimately, the addition of the name app part is to support the new pre.py that doesn't assume app is the folder everything is copied into.
DrewScoggins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I would like to hear back from @akoeplinger about the provisioning script
Adds IPA file usage for iOS Maui SOD. This included adding necessary profile signing and provisioning in the building steps, piping the changes through the pipeline, and making changes in the Perf repository to support them.