Adds benchmarks for GetChildKeys#2336
Merged
adamsitnik merged 3 commits intodotnet:mainfrom Aug 31, 2022
Merged
Conversation
adamsitnik
reviewed
Mar 30, 2022
Member
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
@maryamariyan thank you for your contribution! PTAL at my comments
src/benchmarks/micro/libraries/Microsoft.Extensions.Configuration/GetChildKeysTests.cs
Show resolved
Hide resolved
src/benchmarks/micro/libraries/Microsoft.Extensions.Configuration/GetChildKeysTests.cs
Outdated
Show resolved
Hide resolved
src/benchmarks/micro/libraries/Microsoft.Extensions.Configuration/GetChildKeysTests.cs
Outdated
Show resolved
Hide resolved
src/benchmarks/micro/libraries/Microsoft.Extensions.Configuration/GetChildKeysTests.cs
Outdated
Show resolved
Hide resolved
src/benchmarks/micro/libraries/Microsoft.Extensions.Configuration/GetChildKeysTests.cs
Outdated
Show resolved
Hide resolved
src/benchmarks/micro/libraries/Microsoft.Extensions.Configuration/GetChildKeysTests.cs
Outdated
Show resolved
Hide resolved
|
|
||
| var keysWithCommonPaths = new Dictionary<string, string>() { }; | ||
| for (int i = 1000; i < 2000; i++) | ||
| { |
Member
There was a problem hiding this comment.
I wonder whether we could use more realistic input (I doubt that our users have 1k of very short keys in the config).
@davidfowl where could we find some real life examples of user configs?
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
Member
|
@adamsitnik are your comments satisfactorily addressed? |
Member
I wish we had more realistic input like real life config files, but I am OK with merging it as it is now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to PR dotnet/runtime#67186
cc: @adamsitnik