Assertion failed 'varDsc->lvType == lcl->gtType || varDsc->lvType == TYP_BLK' in 'System.Reflection.CustomAttribute:CreateCaObject(System.Reflection.RuntimeModule,System.RuntimeType,System.IRuntimeMethodInfo,byref,long,byref):System.Object'

[BruceForstall]

Windows x64 Checked (possibly other configurations as well),

Failure in Loader\binding\tracing\BinderTracingTest\BinderTracingTest.cmd with COMPlus_JitStress=1 or 2, and with tiering enabled. With complus_TieredCompilation=0, it doesn't repro. Also passes with COMPlus_JITMinOpts=1.

https://dev.azure.com/dnceng/public/_build/results?buildId=482702&view=ms.vss-test-web.build-test-results-tab&runId=15325494&resultId=110322&paneView=debug

Assert failure(PID 18164 [0x000046f4], Thread: 17768 [0x4568]): Assertion failed 'varDsc->lvType == lcl->gtType || varDsc->lvType == TYP_BLK' in 'System.Reflection.CustomAttribute:CreateCaObject(System.Reflection.RuntimeModule,System.RuntimeType,System.IRuntimeMethodInfo,byref,long,byref):System.Object' (IL size 46)

    File: F:\gh\runtime2\src\coreclr\src\jit\lclvars.cpp Line: 7363
    Image: F:\gh\runtime2\artifacts\tests\coreclr\Windows_NT.x64.Checked\Tests\Core_Root\CoreRun.exe

[BruceForstall]

@dotnet/jit-contrib

[briansull]

This test fails here:

COMPLUS_JitDump=CustomAttribute:CreateCaObject

tail JitDump

*************** In fgRetypeImplicitByRefArgs()


*** JitStress: STRESS_LCL_FLDS ***


Local V06 should not be enregistered because: it is address exposed

[mikedn]

Looks like a variation or side effect of #1704

[briansull]

We hit this assert with a mismatch of varDsc->lvType == lcl->gtType

    else
    {
        // Do the morphing
        noway_assert(varDsc->lvType == lcl->gtType || varDsc->lvType == TYP_BLK);

We have varDsc->lvType == TYP_INT
and lcl->gtType == TYP_LONG

[briansull]

We are processing this tree:

STMT00002 (IL 0x010...0x01F)
               [000019] -AC-G-------              *  ASG       ref   
               [000018] D------N----              +--*  LCL_VAR   ref    V09 loc3         
               [000017] --C-G-------              \--*  CALL      ref    System.Reflection.CustomAttribute._CreateCaObject
               [000009] ------------ arg0            +--*  LCL_VAR   ref    V00 arg0         
               [000010] ------------ arg1            +--*  LCL_VAR   ref    V01 arg1         
               [000011] ------------ arg2            +--*  LCL_VAR   ref    V02 arg2         
               [000013] ------------ arg3            +--*  LCL_VAR_ADDR long   V06 loc0         
               [000014] ------------ arg4            +--*  LCL_VAR   long   V07 loc1         
               [000016] ------------ arg5            \--*  LCL_VAR_ADDR long   V08 loc2     <<<< This node   

[briansull]

It was previously:

STMT00002 (IL 0x010...  ???)
               [000019] -AC-G-------              *  ASG       ref   
               [000018] D------N----              +--*  LCL_VAR   ref    V09 loc3         
               [000017] --C-G-------              \--*  CALL      ref    System.Reflection.CustomAttribute._CreateCaObject
               [000009] ------------ arg0            +--*  LCL_VAR   ref    V00 arg0         
               [000010] ------------ arg1            +--*  LCL_VAR   ref    V01 arg1         
               [000011] ------------ arg2            +--*  LCL_VAR   ref    V02 arg2         
               [000013] ------------ arg3            +--*  ADDR      long  
               [000012] ------------                 |  \--*  LCL_VAR   long   V06 loc0         
               [000014] ------------ arg4            +--*  LCL_VAR   long   V07 loc1         
               [000016] ------------ arg5            \--*  ADDR      long  
               [000015] ------------                    \--*  LCL_VAR   int    V08 loc2  

[briansull]

Signature for System.Reflection.CustomAttribute._CreateCaObject

In impImport() for System.Reflection.CustomAttribute:CreateCaObject(System.Reflection.RuntimeModule,System.RuntimeType,System.IRuntimeMethodInfo,byref,long,byref):System.Object

[briansull]

It looks like byref parameters translate to:

            \--*  ADDR      long  
              \--*  LCL_VAR   int    V08 loc2  

It would seem correct to use TYP_I_IMPL which would be TYP_INT not TYP_LONG on a 64-bit system.

[mikedn]

This is just a side effect of introducing GT_LCL_FLD|VAR_ADDR. I didn't notice this stress lcl fld thing when I did that and now the assert fails because it doesn't expect the node and variable type to be different. Of course they are different for local address nodes since the local address node type is always TYP_I_IMPL while the variable type can be anything.