Fixes runtime issue #1739 #1840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added additional check for Jit Stress mode STRESS_LCL_FLDS This stress mode requires that the types exactly match
Contributor
Author
|
@dotnet/jit-contrib PTAL |
sandreenko
added
the
area-CodeGen-coreclr
AndyAyersMS
approved these changes
Jan 16, 2020
Member
AndyAyersMS
left a comment
AndyAyersMS
left a comment
There was a problem hiding this comment.
Changes LGTM.
I wonder if this stress mode provides a lot of value.
src/coreclr/src/jit/lclvars.cpp
Outdated
|
|
||
| // The assert in the second pass below, requires that these types match, or we have a TYP_BLK | ||
| // | ||
| if ((varDsc->lvType != lcl->gtType) && varDsc->lvType != TYP_BLK) |
Member
There was a problem hiding this comment.
Nit: parens on the second part of the conditional...
Contributor
Author
There was a problem hiding this comment.
Updated with extra parens in both places
Contributor
Author
|
The only test failure is due to the current issue with EvenPipe timeouts due to a deadlock: |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional check for Jit Stress mode STRESS_LCL_FLDS
This stress mode requires that the types exactly match
Fixes #1739