BufferedAsyncFileStreamStandaloneConformanceTests.Read_EmptyStream_Nop_Success failing with PNSE

[antonfirsov]

Test

System.IO.Tests.BufferedAsyncFileStreamStandaloneConformanceTests.Read_EmptyStream_Nop_Success
(Multiple variants)

• Failing since 30/10 Add stream conformance tests for standalone streams #44069
• On queues: ubuntu.1804.amd64.open, windows.10.amd64.server19h1.es.open, windows.81.amd64.open

https://dev.azure.com/dnceng/public/_build/results?buildId=874130&view=ms.vss-test-web.build-test-results-tab

Error Message

Linux:

System.PlatformNotSupportedException : Cannot wait on monitors on this runtime.

Windows:

System.PlatformNotSupportedException : This API is specific to the way in which Windows handles asynchronous I/O, and is not supported on this platform.

Stack Trace

Linux

Details

   at System.Threading.Monitor.ObjWait(Int32 millisecondsTimeout, Object obj)
   at System.Threading.Monitor.Wait(Object obj, Int32 millisecondsTimeout)
   at System.Threading.ManualResetEventSlim.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at System.Threading.Tasks.Task.SpinThenBlockingWait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at System.Threading.Tasks.Task.InternalWaitCore(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at System.Threading.Tasks.Task.InternalWait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at System.IO.FileStream.Read(Byte[] buffer, Int32 offset, Int32 count)
   at System.IO.Stream.Read(Span`1 buffer)
   at System.IO.FileStream.Read(Span`1 buffer)
   at System.IO.Tests.StreamConformanceTests.ReadAsync(ReadWriteMode mode, Stream stream, Byte[] buffer, Int32 offset, Int32 count, CancellationToken cancellationToken)
   at System.IO.Tests.StandaloneStreamConformanceTests.Read_EmptyStream_Nop_Success(ReadWriteMode mode)
--- End of stack trace from previous location ---

Windows

Details

   at System.Threading.ThreadPoolBoundHandle.BindHandle(SafeHandle handle) in /_/src/libraries/System.Private.CoreLib/src/System/Threading/ThreadPoolBoundHandle.PlatformNotSupported.cs:line 24
   at System.IO.FileStream.Init(FileMode mode, FileShare share, String originalPath) in /_/src/libraries/System.Private.CoreLib/src/System/IO/FileStream.Windows.cs:line 91
   at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options) in /_/src/libraries/System.Private.CoreLib/src/System/IO/FileStream.cs:line 252
   at System.IO.Tests.FileStreamStandaloneConformanceTests.CreateStream(Byte[] initialData, FileAccess access) in /_/src/libraries/System.IO.FileSystem/tests/FileStream/FileStreamConformanceTests.cs:line 23
   at System.IO.Tests.FileStreamStandaloneConformanceTests.CreateReadOnlyStreamCore(Byte[] initialData) in /_/src/libraries/System.IO.FileSystem/tests/FileStream/FileStreamConformanceTests.cs:line 26
   at System.IO.Tests.StandaloneStreamConformanceTests.CreateReadOnlyStream(Byte[] initialData) in /_/src/libraries/Common/tests/Tests/System/IO/StreamConformanceTests.cs:line 653
   at System.IO.Tests.StandaloneStreamConformanceTests.Read_EmptyStream_Nop_Success(ReadWriteMode mode) in /_/src/libraries/Common/tests/Tests/System/IO/StreamConformanceTests.cs:line 833
--- End of stack trace from previous location ---

[stephentoub]

Failing since 30/10

This test is new in master as of 17 hours ago.

On queues: ubuntu.1804.amd64.open, windows.10.amd64.server19h1.es.open, windows.81.amd64.open

For reference, the key part isn't actually the queue, it's that it's mono wasm.

[antonfirsov]

This test is new in master as of 17 hours ago.

Sorry for the misleading info, I've been seeing failures from #44069 in my Kusto query actually.

For reference, the key part isn't actually the queue, it's that it's mono wasm.

Yeah I also suspected that, just wasn't able to find the relevant Kusto field.

[stephentoub]

Are you seeing the Windows failure you cited above in an active PR against master, or just from my PR where I was writing the test?

[stephentoub]

And, actually, I'm not clear on why the cited test actually ran:
https://dev.azure.com/dnceng/public/_build/results?buildId=874130&view=ms.vss-test-web.build-test-results-tab
The base class of the test class has this on it:

runtime/src/libraries/Common/tests/Tests/System/IO/StreamConformanceTests.cs

Line 21 in 5dcbc84

[PlatformSpecific(~TestPlatforms.Browser)] // lots of operations aren't supported on browser

@ViktorHofer, that should have prevented this from running, no?

[antonfirsov]

Are you seeing the Windows failure you cited above in an active PR against master, or just from my PR where I was writing the test?

Windows failure seems to be specific to the PR, Ubuntu failures are happening in new PR-s.

I've also encountered a failure of Read_PartiallySatisfied_RemainderOfBufferUntouched in #44202, which seems to be related:
https://dev.azure.com/dnceng/public/_build/results?buildId=874355&view=ms.vss-test-web.build-test-results-tab
(net6.0-Browser-Release-wasm-Mono_Release-wasmtestonbrowser-Ubuntu.1804.Amd64.Open)

Same characteristics: started failing on Ubuntu today.

[stephentoub]

Trying a different mechanism for disabling it here: https://github.com/dotnet/runtime/pull/44218/files

[ViktorHofer]

@ViktorHofer, that should have prevented this from running, no?

It should. The platform check is here: https://github.com/dotnet/arcade/blob/4873d157a8f34f8cc7e28b3f9938b32c642ef542/src/Microsoft.DotNet.XUnitExtensions/src/DiscovererHelpers.cs#L32.

@safern any idea why this didn't work? Both the conditionalclass attribute that stephen is using in his PR and the platformspecific attribute are using ITraitDiscoverer.