Add stream conformance tests for standalone streams #44069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
force-pushed
the
morestreamtests
branch
2 times, most recently
from
5a664ec to
9018125
Compare
This was referenced Nov 2, 2020
stephentoub
force-pushed
the
morestreamtests
branch
2 times, most recently
from
e2fd4c6 to
dfbed8f
Compare
geoffkizer
reviewed
Nov 2, 2020
src/libraries/Common/tests/Tests/System/IO/StreamConformanceTests.cs
Outdated
Show resolved
Hide resolved
geoffkizer
reviewed
Nov 2, 2020
src/libraries/Common/tests/Tests/System/IO/StreamConformanceTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
force-pushed
the
morestreamtests
branch
from
dfbed8f to
57da1f5
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I previously added a stream test suite for streams that could be created in a connected fashion, such that writing to one stream yields data that can be read by another. That enabled testing of a bunch of streams like NetworkStream, SslStream, BufferedStream, etc., even FileStream when wrapped around a pipe.
This PR augments the suite for standalone streams that aren't connected in that fashion. This includes MemoryStream, FileStream for on-disk files, UnmanagedMemoryStream, MemoryMappedViewStream, etc. As with the previous PR, even though it's adding a lot of coverage, total line count is reduced, because it's consolidating tests that were unique to an individual test suite.
I also added a couple of tests to the existing connected suite.
cc: @geoffkizer, @carlossanlop, @jozkee