ARM64 - Assertion failed 'isSharedConst' in 'Test:Main():int' during 'Optimize Valnum CSEs'

[VincentBu]

Run: runtime-coreclr r2r-extra 20210227.1

Error message:

Assert failure(PID 627 [0x00000273], Thread: 627 [0x0273]): Assertion failed 'isSharedConst' in 'Test:Main():int' during 'Optimize Valnum CSEs' (IL size 1828)

 File: /__w/1/s/src/coreclr/jit/optcse.cpp Line: 2866
 Image: /root/helix/work/correlation/crossgen

/root/helix/work/workitem/Loader/classloader/generics/Instantiation/Positive/NestedStruct01/NestedStruct01.sh: line 188: 627 Aborted (core dumped) __Command=$_DebuggerFullPath "$CORE_ROOT/crossgen" /Platform_Assemblies_Paths $CORE_ROOT:$PWD /in NestedStruct01.org /out NestedStruct01.dll
Managed assembly not found: No such file or directory

Return code: 1
Raw output file: /root/helix/work/workitem/Loader/classloader/Reports/Loader.classloader/generics/Instantiation/Positive/NestedStruct01/NestedStruct01.output.txt
Raw output:
BEGIN EXECUTION
in takeLock
Microsoft (R) CoreCLR Native Image Generator - Version 6.0.0-ci
Copyright (c) Microsoft Corporation. All rights reserved.


in ReleaseLock
in takeLock
/root/helix/work/correlation/corerun NestedStruct01.dll ''
in ReleaseLock
Expected: 100
Actual: 255
END EXECUTION - FAILED
Test Harness Exitcode is : 1
To run the test:
> set CORE_ROOT=/root/helix/work/correlation
> /root/helix/work/workitem/Loader/classloader/generics/Instantiation/Positive/NestedStruct01/NestedStruct01.sh
Expected: True
Actual: False

Stack trace
   at Loader_classloader._generics_Instantiation_Positive_NestedStruct01_NestedStruct01_._generics_Instantiation_Positive_NestedStruct01_NestedStruct01_sh()

[BruceForstall]

Probable regression from #44419

[BruceForstall]

@briansull
cc @dotnet/jit-contrib

[briansull]

I will take a look

[briansull]

I am having trouble trying to get a repro for this.
These repro instructions don't help me too much
I don't seem to have a local copy/build of dotnet-cli in my enlistment

My test builds doesn't have JIT\Generics\Typeof\struct01\struct01.cmd, but maybe this is a priority 1 test, so I am rebuilding the tests.

Console log: 'JIT.Generics' from job 891322ae-b17c-423e-9045-13b35c3cea9c workitem a081aa27-1693-4c87-accf-c0ab9506947b (windows.10.arm64v8.open) executed on machine DDARM64-063

D:\h\w\A250093A\w\AC300970\e>set CORE_ROOT=D:\h\w\A250093A\p 

D:\h\w\A250093A\w\AC300970\e>set _NT_SYMBOL_PATH=D:\h\w\A250093A\p\PDB 

D:\h\w\A250093A\w\AC300970\e>set RunCrossGen=1 

D:\h\w\A250093A\w\AC300970\e>set __TestEnv=D:\h\w\A250093A\w\AC300970\u\SetStressModes_jitstress1_tiered.cmd 

D:\h\w\A250093A\w\AC300970\e>set __TestTimeout=5400000 

D:\h\w\A250093A\w\AC300970\e>set __CollectDumps=1 

D:\h\w\A250093A\w\AC300970\e>set __CrashDumpFolder=C:\cores 

D:\h\w\A250093A\w\AC300970\e>type D:\h\w\A250093A\w\AC300970\u\SetStressModes_jitstress1_tiered.cmd 
set COMPlus_TieredCompilation=1
set COMPlus_JitStress=1

D:\h\w\A250093A\w\AC300970\e>set PATH=D:\h\w\A250093A\p\dotnet-cli;C:\python3.7.0\lib\site-packages\pywin32_system32;C:\python3.7.0\Scripts\;C:\python3.7.0\;D:\Windows\system32;D:\Windows;D:\Windows\System32\Wbem;D:\Windows\System32\WindowsPowerShell\v1.0\;D:\Windows\System32\OpenSSH\;D:\Users\runner\AppData\Local\Microsoft\WindowsApps 

D:\h\w\A250093A\w\AC300970\e>set DOTNET_ROOT=D:\h\w\A250093A\p\dotnet-cli 

D:\h\w\A250093A\w\AC300970\e>set DOTNET_CLI_TELEMETRY_OPTOUT=1 

D:\h\w\A250093A\w\AC300970\e>dotnet D:\h\w\A250093A\p\xunit\xunit.console.dll JIT\Generics\JIT.Generics.XUnitWrapper.dll -parallel collections -nocolor -noshadow -xml testResults.xml -trait TestGroup=JIT.Generics 
Microsoft.DotNet.XUnitConsoleRunner v2.5.0 (64-bit .NET 6.0.0-preview.2.21117.5)
  Discovering: JIT.Generics.XUnitWrapper
  Discovered:  JIT.Generics.XUnitWrapper
  Starting:    JIT.Generics.XUnitWrapper
    JIT\Generics\Typeof\struct01\struct01.cmd [FAIL]
      
      Assert failure(PID 15280 [0x00003bb0], Thread: 8764 [0x223c]): Assertion failed 'isSharedConst' in 'Test:Main():int' during 'Optimize Valnum CSEs' (IL size 1828)
      
          File: D:\workspace\_work\1\s\src\coreclr\jit\optcse.cpp Line: 2866
          Image: D:\h\w\A250093A\p\crossgen.exe
      
      
      Return code:      1
      Raw output file:      D:\h\w\A250093A\w\AC300970\e\JIT\Generics\Reports\JIT.Generics\Typeof\struct01\struct01.output.txt
      Raw output:
      BEGIN EXECUTION
              1 file(s) copied.
      " "D:\h\w\A250093A\p\crossgen.exe"  /Platform_Assemblies_Paths D:\h\w\A250093A\p;D:\h\w\A250093A\w\AC300970\e\JIT\Generics\Typeof\struct01 /in D:\h\w\A250093A\w\AC300970\e\JIT\Generics\Typeof\struct01\struct01.org /out D:\h\w\A250093A\w\AC300970\e\JIT\Generics\Typeof\struct01\\struct01.dll"
      Microsoft (R) CoreCLR Native Image Generator - Version 6.0.0-ci
      Copyright (c) Microsoft Corporation.  All rights reserved.
      
      Crossgen failed with exitcode - -1073740286
      Test Harness Exitcode is : 1
      To run the test:
      > set CORE_ROOT=D:\h\w\A250093A\p
      > D:\h\w\A250093A\w\AC300970\e\JIT\Generics\Typeof\struct01\struct01.cmd

[briansull]

I tried running:

C:\fxkit\runtime\artifacts\tests\coreclr\windows.x64.Checked\JIT\Generics>dir *.dll
 Volume in drive C is Windows
 Volume Serial Number is 52AD-CDBD

 Directory of C:\fxkit\runtime\artifacts\tests\coreclr\windows.x64.Checked\JIT\Generics

02/26/2021  08:19 PM            12,288 Coreclr.TestWrapper.dll
02/26/2021  08:20 PM            60,416 JIT.Generics.XUnitWrapper.dll

CORE_ROOT=C:\fxkit\runtime\artifacts\tests\coreclr\windows.x64.Checked\Tests\Core_Root

C:\fxkit\runtime\artifacts\tests\coreclr\windows.x64.Checked\JIT\Generics>dotnet %CORE_ROOT%\xunit\xunit.console.dll JIT.Generics.XUnitWrapper.dll
Microsoft.DotNet.XUnitConsoleRunner v2.5.0 (64-bit .NET 5.0.3)
System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.

[briansull]

Running this command passes:

set RunCrossGen=1
set COMPlus_JitStress=1
set COMPlus_TieredCompilation=1
set CORE_ROOT=C:\fxkit\runtime\artifacts\tests\coreclr\windows.x64.Checked\Tests\Core_Root

C:\fxkit\runtime\artifacts\tests\coreclr\windows.x64.Checked\JIT\Generics\Typeof\struct01>struct01.cmd
BEGIN EXECUTION
 "C:\fxkit\runtime\artifacts\tests\coreclr\windows.x64.Checked\Tests\Core_Root\corerun.exe" struct01.dll
Test Passed
Expected: 100
Actual: 100
END EXECUTION - PASSED
PASSED

[BruceForstall]

@briansull all the failures are on arm64:

https://dev.azure.com/dnceng/public/_build/results?buildId=1015629&view=ms.vss-test-web.build-test-results-tab