Skip to content

Don't use the CoercedConstantValue value as the key, when we have a reloc #49029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
briansull merged 2 commits into from
Mar 4, 2021
Merged

Don't use the CoercedConstantValue value as the key, when we have a reloc #49029

briansull merged 2 commits into from
Mar 4, 2021

Conversation

@briansull
Copy link
Contributor

@briansull briansull commented Mar 2, 2021

Instead just use the vnLibNorm

Fixes #48895

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 2, 2021
@BruceForstall
Copy link
Contributor

BruceForstall commented Mar 2, 2021

Trigger the "runtime-coreclr r2r-extra" pipeline to verify

@briansull
Copy link
Contributor Author

briansull commented Mar 2, 2021

/azp run runtime-coreclr r2r-extra

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 2, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@briansull
Copy link
Contributor Author

briansull commented Mar 3, 2021 •
edited
Loading

The failures that occur are due to a different issue, a file not found error when doing a crossgen of CORE_ROOT

Generate CORE_ROOT

104 / 261 (38%, 0 failed): launching: D:\workspace\_work\1\s\artifacts\bin\coreclr\windows.x64.Checked\crossgen.exe @D:\workspace\_work\1\s\artifacts\tests\coreclr\obj\windows.x64.Checked\crossgen.out\Microsoft.Extensions.DependencyInjection.Specification.Tests.dll.rsp Error: Could not load file or assembly 'System.TestStructs, Version=1.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified. (0x80070002 (COR_E_FILENOTFOUND))

@BruceForstall
Copy link
Contributor

BruceForstall commented Mar 3, 2021

I kicked off a 'main' branch baseline run so you can see if it also fails in baseline: https://dev.azure.com/dnceng/public/_build/results?buildId=1020021&view=results

@briansull
Copy link
Contributor Author

briansull commented Mar 3, 2021

Thanks Bruce

@briansull
Copy link
Contributor Author

briansull commented Mar 3, 2021 •
edited
Loading

The errors the we get when running crossgen to create CORE_ROOT could be caused by:

PR #48858 Build Micrososoft.Extensions.DependencyInjection.Specification.Tests package (checked in 8 hours ago)

@briansull
Copy link
Contributor Author

briansull commented Mar 3, 2021

We are seeing the same regression in the 'main' branch baseline run.
This checkin is blocked until that is fixed

@briansull
Copy link
Contributor Author

briansull commented Mar 3, 2021

/azp run runtime-coreclr r2r-extra

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 3, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@briansull
Copy link
Contributor Author

briansull commented Mar 3, 2021

/azp run runtime-coreclr r2r-extra

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 3, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@briansull
Copy link
Contributor Author

briansull commented Mar 4, 2021

@BruceForstall @AndyAyersMS

This fixes the issue with the assert failure on arm64 #48895
We now successfully build the CORE_ROOT folder fin the R2RTest leg now.

I will check this fix in after you approve it.

@briansull
Copy link
Contributor Author

briansull commented Mar 4, 2021 •
edited
Loading

Task failure: runtime (CoreCLR Pri0 Runtime Tests Run windows arm64 checked)

Discovering: readytorun.multifolder.XUnitWrapper
  Discovered:  readytorun.multifolder.XUnitWrapper
  Starting:    readytorun.multifolder.XUnitWrapper
System.InvalidOperationException: Collection was modified after the enumerator was instantiated.
   at System.Collections.Generic.Stack`1.Enumerator.MoveNext()
   at Xunit.Sdk.DisposalTracker.Dispose() in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\DisposalTracker.cs:line 26

Looks similar to existing issue: #11063

@BruceForstall
Copy link
Contributor

BruceForstall commented Mar 4, 2021

r2r-extra was clean. amazing!

AndyAyersMS
AndyAyersMS reviewed Mar 4, 2021
View reviewed changes
@briansull
Copy link
Contributor Author

briansull commented Mar 4, 2021

/azp run runtime-coreclr r2r-extra

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 4, 2021

Azure Pipelines successfully started running 1 pipeline(s).

AndyAyersMS
AndyAyersMS approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@briansull briansull merged commit f15ab14 into dotnet:main Mar 4, 2021
@runfoapp runfoapp bot mentioned this pull request Mar 4, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Apr 3, 2021
@JulieLeeMSFT JulieLeeMSFT added this to the 6.0.0 milestone Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

+1 more reviewer

@BruceForstall BruceForstall BruceForstall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@briansull briansull

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

ARM64 - Assertion failed 'isSharedConst' in 'Test:Main():int' during 'Optimize Valnum CSEs'

4 participants

@briansull @BruceForstall @AndyAyersMS @JulieLeeMSFT