[release/7.0][wasm] Debugger test `ExceptionTestUncaughtWithReload` failing

[radical]

Build, and
log:

[xUnit.net 00:39:47.90]     DebuggerTests.ExceptionTests.ExceptionTestUncaughtWithReload [FAIL]
  Failed DebuggerTests.ExceptionTests.ExceptionTestUncaughtWithReload [1 s]
  Error Message:
   [pause1]

Expected: DebuggerTests.ExceptionTestsClass.TestUncaughtException.run
Actual:   invoke_static_method
  Stack Trace:
     at DebuggerTests.DebuggerTestBase.AssertEqual(Object expected, Object actual, String label) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 1184
   at DebuggerTests.ExceptionTests.ExceptionTestUncaughtWithReload() in /_/src/mono/wasm/debugger/DebuggerTestSuite/ExceptionTests.cs:line 251
--- End of stack trace from previous location ---
[Result: IsOk: True, IsErr: False, Value: {
  "breakpointId": "1:539:8:dotnet://debugger-test.dll//_/src/mono/wasm/debugger/tests/debugger-test/debugger-test.cs",
  "locations": [
    {
      "scriptId": "dotnet://27014_1",
      "lineNumber": 542,
      "columnNumber": 8
    }
  ]
}, Error:  ]
[Result: IsOk: True, IsErr: False, Value: {
  "breakpointId": "1:1272:8:dotnet://debugger-test.dll//_/src/mono/wasm/debugger/tests/debugger-test/debugger-test.cs",
  "locations": []
}, Error:  ]

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Build, and
log:

[xUnit.net 00:39:47.90]     DebuggerTests.ExceptionTests.ExceptionTestUncaughtWithReload [FAIL]
  Failed DebuggerTests.ExceptionTests.ExceptionTestUncaughtWithReload [1 s]
  Error Message:
   [pause1]

Expected: DebuggerTests.ExceptionTestsClass.TestUncaughtException.run
Actual:   invoke_static_method
  Stack Trace:
     at DebuggerTests.DebuggerTestBase.AssertEqual(Object expected, Object actual, String label) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 1184
   at DebuggerTests.ExceptionTests.ExceptionTestUncaughtWithReload() in /_/src/mono/wasm/debugger/DebuggerTestSuite/ExceptionTests.cs:line 251
--- End of stack trace from previous location ---
[Result: IsOk: True, IsErr: False, Value: {
  "breakpointId": "1:539:8:dotnet://debugger-test.dll//_/src/mono/wasm/debugger/tests/debugger-test/debugger-test.cs",
  "locations": [
    {
      "scriptId": "dotnet://27014_1",
      "lineNumber": 542,
      "columnNumber": 8
    }
  ]
}, Error:  ]
[Result: IsOk: True, IsErr: False, Value: {
  "breakpointId": "1:1272:8:dotnet://debugger-test.dll//_/src/mono/wasm/debugger/tests/debugger-test/debugger-test.cs",
  "locations": []
}, Error:  ]

Author:	radical
Assignees:	-
Labels:	arch-wasm, area-Debugger-mono, test-failure
Milestone:	-

[ilonatommy]

I can't reproduce, neither on release/7.0 nor on main.

[radical]

@ilonatommy this test is racy because it uses Thread.Sleep(1000)(https://github.com/dotnet/runtime/blob/main/src/mono/wasm/debugger/DebuggerTestSuite/ExceptionTests.cs#L241). The test is sending a Page.reload, and wants to run rest of the test once that is complete. But at the end of Thread.Sleep(1000), the page might not have completed reloading.

To avoid that we want to use some deterministic signal that the page is ready. you could use await insp.WaitFor(Inspector.APP_READY).

runtime/src/mono/wasm/debugger/DebuggerTestSuite/BreakpointTests.cs

Lines 792 to 797 in a889912

	run_method = JObject.FromObject(new
	{
	expression = "window.setTimeout(function() { reload_wasm_page(); }, 1);"
	});
	await cli.SendCommand("Runtime.evaluate", run_method, token);
	await insp.WaitFor(Inspector.APP_READY);

This is one example. And in fact CreateGoodBreakpointAndHitGoToNonWasmPageComeBackAndHitAgain needs a similar fix:

runtime/src/mono/wasm/debugger/DebuggerTestSuite/BreakpointTests.cs

Lines 507 to 514 in a889912

	await cli.SendCommand("Runtime.evaluate", run_method, token);
	await Task.Delay(1000, token);
	run_method = JObject.FromObject(new
	{
	expression = "window.setTimeout(function() { reload_wasm_page(); }, 1);"
	});
	await cli.SendCommand("Runtime.evaluate", run_method, token);